Repository navigation
Conversation
ocombe
approved these changes
Jun 25, 2018
ocombe
added
comp: docs
area: common
Contributor
|
See also this pending PR on rounding behavior: |
1 of 3 tasks
Adds an example of using the `currency` pipe with a currency that has no cents like CLP,
which will format the amount with no digits if `digitsInfo` is not provided:
<!-- outputs CA$14.00 -->
{{ 14 | currency:'CAD' }}
<!-- outputs CLP14 -->
{{ 14 | currency:'CLP' }}
Amends the docs, adds an example and fix an error with a current example.
cexbrayat
force-pushed
the
fix/currency-docs
branch
from
June 25, 2018 21:18
4367d5d to
98978c0
Compare
Contributor
|
@vicb will you provide an approval for this PR? |
Contributor
vicb
approved these changes
Jul 20, 2018
vicb
pushed a commit
that referenced
this pull request
Jul 20, 2018
Adds an example of using the `currency` pipe with a currency that has no cents like CLP,
which will format the amount with no digits if `digitsInfo` is not provided:
<!-- outputs CA$14.00 -->
{{ 14 | currency:'CAD' }}
<!-- outputs CLP14 -->
{{ 14 | currency:'CLP' }}
Amends the docs, adds an example and fix an error with a current example.
PR Close #24661
3 tasks done
cexbrayat
added a commit
to cexbrayat/angular
that referenced
this pull request
Jul 22, 2018
Will avoid errors in examples like the one fixed in angular#24661
vicb
pushed a commit
that referenced
this pull request
Jul 23, 2018
vicb
pushed a commit
that referenced
this pull request
Jul 23, 2018
jenniferfell
added
the
state: community
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an example of using the
currencypipe with a currency that has no cents like CLP,which will format the amount with no digits if
digitsInfois not provided:Amends the docs, adds an example and fix an error with a current example.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
See #24141 (comment)
What is the new behavior?
Adds a small example of using the currency pipe with no
digitsInfoand with a currency that has no cents to illustrate that the formatting done by the pipe by default follows the ISO 4217 specification.Does this PR introduce a breaking change?
Other information