feat: typescript 2.9 support by IgorMinar · Pull Request #24652 · angular/angular

IgorMinar · 2018-06-25T09:12:29Z

known issues:

one of the e2e tests are failing because of somehow we don't generate proper amd modules within bazel pipeline. This might be a tsickle 0.30.0 issues. I'm not sure. @alexeagle could you help plz?
one of the tests for the compiler's metadata compiler is failing. it seems to me that the new behavior is actually correct, but I'd like a clarification from @alxhub plz
there is one more failing test from the runtime ~~I haven't investigated this yet.~~ - the issue identified with a runtime error due to undefined "selector" property seems to be a breakage in the master/HEAD and unrelated to my change.
the pr needs to be reformatted

IgorMinar · 2018-06-25T09:22:54Z

@fyi: @mprobst, @mhevery, @manughub

mprobst · 2018-06-25T09:27:43Z

Nice!

JoostK · 2018-06-25T09:41:33Z

Haha, nice one but still incorrect :)

EatonZ · 2018-06-25T20:33:43Z

Just an FYI.. you have 2.10 in a few spots here. The next version is actually 3.0.

mprobst · 2018-06-27T13:19:57Z

@IgorMinar what's the status of this? We'd like to move google3 to TS2.9 and are blocked on this.

mhevery · 2018-06-27T21:46:16Z

Since @IgorMinar is on vacation, I will take over this PR.

googlebot · 2018-06-27T23:16:39Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2018-06-27T23:17:30Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

googlebot · 2018-06-28T16:32:40Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2018-06-28T16:38:47Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

mhevery · 2018-06-28T17:41:41Z

Blocked on angular/tsickle#846

googlebot · 2018-06-28T18:15:36Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2018-07-03T17:16:05Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

mhevery · 2018-07-03T17:22:54Z

http://test/OCL:203143205:BASE:203143231:1530638557253:a92f7ca2

mary-poppins · 2018-07-03T17:22:58Z

You can preview e601954 at https://pr24652-e601954.ngbuilds.io/.

googlebot · 2018-07-03T19:29:48Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

mary-poppins · 2018-07-03T19:38:53Z

You can preview fd69070 at https://pr24652-fd69070.ngbuilds.io/.

mary-poppins · 2018-07-03T19:40:53Z

You can preview 5331d1b at https://pr24652-5331d1b.ngbuilds.io/.

googlebot · 2018-07-03T20:21:30Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

cexbrayat · 2018-07-03T21:22:08Z

+    "@angular/upgrade": "file:../../dist/packages-dist/upgrade",
+    "@types/jasmine": "2.5.41",
+    "rxjs": "file:../../node_modules/rxjs",
+    "typescript": "2.8.x",


@mhevery Is it not weird to have 2.8.x in the package.json of typings_test_ts29. Shouldn't that be 2.9.x (and in the description above)

I opened #24749 to fix it

good catch, and thanks for the fix.

angular-automatic-lock-bot · 2019-09-13T19:22:09Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jun 25, 2018

JoostK reviewed Jun 25, 2018

View reviewed changes

ericmartinezr mentioned this pull request Jun 25, 2018

Add support for TypeScript 2.8 #23779

Closed

6 of 7 tasks

mhevery self-assigned this Jun 26, 2018

mhevery force-pushed the build/tsc-2.9 branch from ea3e466 to 2363ee3 Compare June 27, 2018 21:57

mhevery added the target: major This PR is targeted for the next major release label Jun 27, 2018

mhevery approved these changes Jun 27, 2018

View reviewed changes

googlebot added cla: no and removed cla: yes labels Jun 27, 2018

mhevery added cla: yes and removed cla: no labels Jun 27, 2018

googlebot added cla: no and removed cla: yes labels Jun 28, 2018

mhevery added cla: yes and removed cla: no labels Jun 28, 2018

googlebot added cla: no and removed cla: yes labels Jun 28, 2018

mhevery added cla: yes and removed cla: no labels Jun 28, 2018

mhevery and others added 9 commits July 3, 2018 10:13

fixup! feat: typescript 2.9 support

5644f8a

fixup! feat: typescript 2.9 support

a45cf8f

fixup! feat: typescript 2.9 support

cca48b1

fixup! feat: typescript 2.9 support

2d95444

fixup! feat: typescript 2.9 support

ba436b2

fixup! feat: typescript 2.9 support

7ddf824

fixup! feat: typescript 2.9 support

955e543

fixup! feat: typescript 2.9 support

db222e6

fixup! feat: typescript 2.9 support

e601954

mhevery force-pushed the build/tsc-2.9 branch from 1518e91 to e601954 Compare July 3, 2018 17:13

mhevery added cla: yes and removed cla: no labels Jul 3, 2018

fixup! feat: typescript 2.9 support

fd69070

googlebot added cla: no and removed cla: yes labels Jul 3, 2018

fixup! feat: typescript 2.9 support

5331d1b

alxhub added cla: yes and removed cla: no labels Jul 3, 2018

mhevery closed this in e3064d5 Jul 3, 2018

cexbrayat reviewed Jul 3, 2018

View reviewed changes

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019

Conversation

IgorMinar commented Jun 25, 2018 • edited by mhevery Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IgorMinar commented Jun 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mprobst commented Jun 25, 2018

Uh oh!

JoostK Jun 25, 2018

Choose a reason for hiding this comment

Uh oh!

mhevery Jun 27, 2018

Choose a reason for hiding this comment

Uh oh!

EatonZ commented Jun 25, 2018

Uh oh!

mprobst commented Jun 27, 2018

Uh oh!

mhevery commented Jun 27, 2018

Uh oh!

googlebot commented Jun 27, 2018

Uh oh!

googlebot commented Jun 27, 2018

Uh oh!

googlebot commented Jun 28, 2018

Uh oh!

googlebot commented Jun 28, 2018

Uh oh!

mhevery commented Jun 28, 2018

Uh oh!

googlebot commented Jun 28, 2018

Uh oh!

googlebot commented Jul 3, 2018

Uh oh!

mhevery commented Jul 3, 2018

Uh oh!

mary-poppins commented Jul 3, 2018

Uh oh!

googlebot commented Jul 3, 2018

Uh oh!

mary-poppins commented Jul 3, 2018

Uh oh!

mary-poppins commented Jul 3, 2018

Uh oh!

googlebot commented Jul 3, 2018

Uh oh!

cexbrayat Jul 3, 2018

Choose a reason for hiding this comment

Uh oh!

cexbrayat Jul 3, 2018

Choose a reason for hiding this comment

Uh oh!

mhevery Jul 6, 2018

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Sep 13, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

IgorMinar commented Jun 25, 2018 •

edited by mhevery

Loading

IgorMinar commented Jun 25, 2018 •

edited

Loading