Skip to content

feat: ability to pass options to service workers fetch requests - #24510

Closed
4F2E4A2E wants to merge 11 commits into
angular:masterfrom
4F2E4A2E:10391-ability-to-pass-options-to-service-workers-fetch-requests
Closed

4F2E4A2E wants to merge 11 commits into
angular:masterfrom
4F2E4A2E:10391-ability-to-pass-options-to-service-workers-fetch-requests

Conversation

@4F2E4A2E

@4F2E4A2E 4F2E4A2E commented Jun 14, 2018 •

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: https://github.com/angular/angular-cli/issues/10391

What is the new behavior?

The fetch api options can now be passed to the service worker.

...
// ngsw-config.js
"index": "/index.html",
  "requestOptions": {
    "credentials": "same-origin"
  },
  "assetGroups": [
    {
...

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Help needed: I could not find a way to pass the requestOptions to the main.ts, line 15 / 16

@4F2E4A2E 4F2E4A2E changed the title ability to pass options to service workers fetch requests feat: ability to pass options to service workers fetch requests Jun 14, 2018
@4F2E4A2E

4F2E4A2E commented Jul 2, 2018

Copy link
Copy Markdown
Author

Branch and PR will be recreated since this one will always fail on circleCI because a wrong commit message that did pass the webhooks.

@4F2E4A2E 4F2E4A2E closed this Jul 2, 2018
@antoinebrault

antoinebrault commented Aug 29, 2019 •

Copy link
Copy Markdown

@4F2E4A2E can't find the code in master, did you recreate branch and PR ?

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants