Skip to content

Doc libraries - #24475

Closed
dariobraun wants to merge 2 commits into
angular:masterfrom
dariobraun:doc_libraries
Closed

Doc libraries#24475
dariobraun wants to merge 2 commits into
angular:masterfrom
dariobraun:doc_libraries

Conversation

@dariobraun

@dariobraun dariobraun commented Jun 13, 2018

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #22158

What is the new behavior?

Clarifies that 'BrowserModule' and 'NgModule' are not different types of modules but that 'BrowserModule' is a sub type.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Dario Braun added 2 commits June 13, 2018 14:56
Dario Braun
Merge pull request #1 from angular/master
61c2f98 
Update fork
Dario Braun
docs: clarify that 'BrowserModule' is an 'NgModule'
83433a5 
As to not confuse the reader, clarify that 'BrowserModule' is one of many 'NgModules'.

Fixes #22158
This was referenced Jun 13, 2018
Closed
Closed
@jbogarthyde

jbogarthyde commented Jun 13, 2018

Copy link
Copy Markdown
Contributor

Thanks for this contribution.
Please check out PR #24481 - what do you think of that fix for this issue?

@dariobraun

dariobraun commented Jun 13, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@jbogarthyde I feel like your version in PR #24481 better fits the overall style of the docs - feel free to close this PR!

@alexeagle alexeagle closed this Jun 13, 2018
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dariobraun @jbogarthyde @alexeagle @googlebot