Repository navigation
Conversation
The legacy "aio" is still active for currently pending PRs, The GH label has been renamed as well
vicb
added
action: review
IgorMinar
approved these changes
Jun 5, 2018
vicb
added
action: merge
vicb
added a commit
that referenced
this pull request
Jun 5, 2018
The legacy "aio" is still active for currently pending PRs, The GH label has been renamed as well PR Close #24295
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Jun 11, 2018
This was referenced Jun 11, 2018
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Aug 27, 2019
The `aio` commit message scope was renamed to `docs-infra` (which is more descriptive) in angular#24295. Although it has been removed from the documentation, the legacy `aio` scope was kept in the [list of valid scopes][1] to cater for in-flight PRs that already used it. As a result, it still shows up as a recommended, valid scope in the error message shown when commit message validation fails during `git commit`. This is misleading, especially for new contributors. Since we have been "manually" discouraging people from using `aio`, there should be no open PRs by now (and if there are, they should be changed to `docs-infra`), so it is safe to remove it from the list of allowed scopes. Related discussion: angular#32273 (review) [1]: https://github.com/angular/angular/blob/3df54be9e/tools/validate-commit-message/commit-message.json#L16
atscott
pushed a commit
that referenced
this pull request
Aug 27, 2019
The `aio` commit message scope was renamed to `docs-infra` (which is more descriptive) in #24295. Although it has been removed from the documentation, the legacy `aio` scope was kept in the [list of valid scopes][1] to cater for in-flight PRs that already used it. As a result, it still shows up as a recommended, valid scope in the error message shown when commit message validation fails during `git commit`. This is misleading, especially for new contributors. Since we have been "manually" discouraging people from using `aio`, there should be no open PRs by now (and if there are, they should be changed to `docs-infra`), so it is safe to remove it from the list of allowed scopes. Related discussion: #32273 (review) [1]: https://github.com/angular/angular/blob/3df54be9e/tools/validate-commit-message/commit-message.json#L16 PR Close #32341
atscott
pushed a commit
that referenced
this pull request
Aug 27, 2019
The `aio` commit message scope was renamed to `docs-infra` (which is more descriptive) in #24295. Although it has been removed from the documentation, the legacy `aio` scope was kept in the [list of valid scopes][1] to cater for in-flight PRs that already used it. As a result, it still shows up as a recommended, valid scope in the error message shown when commit message validation fails during `git commit`. This is misleading, especially for new contributors. Since we have been "manually" discouraging people from using `aio`, there should be no open PRs by now (and if there are, they should be changed to `docs-infra`), so it is safe to remove it from the list of allowed scopes. Related discussion: #32273 (review) [1]: https://github.com/angular/angular/blob/3df54be9e/tools/validate-commit-message/commit-message.json#L16 PR Close #32341
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
The `aio` commit message scope was renamed to `docs-infra` (which is more descriptive) in angular#24295. Although it has been removed from the documentation, the legacy `aio` scope was kept in the [list of valid scopes][1] to cater for in-flight PRs that already used it. As a result, it still shows up as a recommended, valid scope in the error message shown when commit message validation fails during `git commit`. This is misleading, especially for new contributors. Since we have been "manually" discouraging people from using `aio`, there should be no open PRs by now (and if there are, they should be changed to `docs-infra`), so it is safe to remove it from the list of allowed scopes. Related discussion: angular#32273 (review) [1]: https://github.com/angular/angular/blob/3df54be9e/tools/validate-commit-message/commit-message.json#L16 PR Close angular#32341
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy "aio" is still active for currently pending PRs,
The GH label has been renamed as well