build: upgrade to TypeScript 2.8 by LucasSloan · Pull Request #23782 · angular/angular

LucasSloan · 2018-05-08T23:40:55Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Builds with TS 2.7
Issue Number: #23092

What is the new behavior?

Builds with TS 2.8.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

mary-poppins · 2018-05-08T23:53:35Z

You can preview 771289c at https://pr23782-771289c.ngbuilds.io/.

ghost · 2018-05-09T03:22:17Z

Shouldn't this title be build: upgrade to TypeScript 2.8?

gkalpak · 2018-05-09T09:10:00Z

Fixed the PR title, but the commit message has to be updated too 😁

LucasSloan · 2018-05-09T17:48:28Z

Whoops, taken care of.

mary-poppins · 2018-05-09T18:00:36Z

You can preview 6cbbf34 at https://pr23782-6cbbf34.ngbuilds.io/.

mary-poppins · 2018-05-09T18:46:45Z

You can preview ea4e2b4 at https://pr23782-ea4e2b4.ngbuilds.io/.

mary-poppins · 2018-05-14T16:36:59Z

You can preview b6075a7 at https://pr23782-b6075a7.ngbuilds.io/.

alxhub · 2018-05-14T17:01:14Z

I'm guessing this should say Typescript 2.8?

That sounds right. I've also gone back and updated the test for 2.7 to say 2.7, not 2.6.

mary-poppins · 2018-05-14T18:20:35Z

You can preview e346628 at https://pr23782-e346628.ngbuilds.io/.

rafaelss95 · 2018-05-14T21:53:47Z

mary-poppins · 2018-05-15T17:22:36Z

You can preview 0f3e647 at https://pr23782-0f3e647.ngbuilds.io/.

IgorMinar

That was actually a pretty smooth update! Thanks Lucas!

Can you please presubmit this with g3sync presubmit 23782 (see go/angular-g3sync). Thanks

IgorMinar · 2018-05-15T17:57:37Z

Lucas, I'm labeling this with merge, but we still need g3 presubmit before the caretaker will merge this. As soon as that's done, the change will be picked up by the caretaker and merged.

LucasSloan · 2018-05-15T18:09:40Z

Running now.

PR Close angular#23782

angular-automatic-lock-bot · 2019-09-13T15:22:55Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

LucasSloan requested a review from alxhub May 8, 2018 23:40

googlebot added the cla: yes label May 8, 2018

gkalpak changed the title ~~build: upgrade to TypeScript 2.7~~ build: upgrade to TypeScript 2.8 May 9, 2018

LucasSloan force-pushed the ts28-upgrade branch from 771289c to 6cbbf34 Compare May 9, 2018 17:47

LucasSloan force-pushed the ts28-upgrade branch from 6cbbf34 to ea4e2b4 Compare May 9, 2018 18:34

LucasSloan force-pushed the ts28-upgrade branch from ea4e2b4 to b6075a7 Compare May 14, 2018 16:23

alxhub approved these changes May 14, 2018

View reviewed changes

LucasSloan force-pushed the ts28-upgrade branch from b6075a7 to e346628 Compare May 14, 2018 17:58

LucasSloan requested a review from IgorMinar May 14, 2018 19:11

rafaelss95 reviewed May 14, 2018

View reviewed changes

build: upgrade to TypeScript 2.8

0f3e647

LucasSloan force-pushed the ts28-upgrade branch from e346628 to 0f3e647 Compare May 15, 2018 17:10

alxhub added the target: major This PR is targeted for the next major release label May 15, 2018

IgorMinar approved these changes May 15, 2018

View reviewed changes

IgorMinar added the action: merge The PR is ready for merge by the caretaker label May 15, 2018

alxhub closed this in 5cf82f8 May 15, 2018

andrewseguin mentioned this pull request May 21, 2018

build(compiler-cli): update tsickle version #23531

Closed

1 of 3 tasks

mashhoodr pushed a commit to mashhoodr/angular that referenced this pull request May 28, 2018

build: upgrade to TypeScript 2.8 (angular#23782)

bb4dd15

PR Close angular#23782

sarunint mentioned this pull request Jun 24, 2018

Add support for TypeScript 2.8 #23779

Closed

6 of 7 tasks

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019

Conversation

LucasSloan commented May 8, 2018

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Uh oh!

mary-poppins commented May 8, 2018

Uh oh!

ghost commented May 9, 2018

Uh oh!

gkalpak commented May 9, 2018

Uh oh!

LucasSloan commented May 9, 2018

Uh oh!

mary-poppins commented May 9, 2018

Uh oh!

mary-poppins commented May 9, 2018

Uh oh!

mary-poppins commented May 14, 2018

Uh oh!

alxhub May 14, 2018

Choose a reason for hiding this comment

Uh oh!

LucasSloan May 14, 2018

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented May 14, 2018

Uh oh!

rafaelss95 May 14, 2018

Choose a reason for hiding this comment

Uh oh!

LucasSloan May 15, 2018

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented May 15, 2018

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

IgorMinar commented May 15, 2018

Uh oh!

LucasSloan commented May 15, 2018

Uh oh!

angular-automatic-lock-bot Bot commented Sep 13, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants