Skip to content

build(compiler-cli): update tsickle version - #23531

Closed
andrewseguin wants to merge 2 commits into
angular:masterfrom
andrewseguin:compiler-cli-tsickle-update
Closed

andrewseguin wants to merge 2 commits into
angular:masterfrom
andrewseguin:compiler-cli-tsickle-update

Conversation

@andrewseguin

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

Updating compiler-cli's tsickle version

@andrewseguin
andrewseguin requested a review from alxhub April 24, 2018 20:32
@andrewseguin andrewseguin added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime and removed cla: yes labels Apr 24, 2018
@mary-poppins

Copy link
Copy Markdown

You can preview c4dd049 at https://pr23531-c4dd049.ngbuilds.io/.

@IgorMinar

Copy link
Copy Markdown
Contributor

what's the motivation for this change? are the previous patch versions broken in a significant way that would want us to ensure we are using the latest? something else?

also if you don't update any lock files, we'll keep on using whatever we are currently using for our own tests, but since none of them are failing, it's really unclear what you are fixing, so more info would be appreciated. thanks!

@andrewseguin

Copy link
Copy Markdown
Contributor Author

The version is being updated to include this fix in tsickle: angular/tsickle#760

The issue is that when Material builds its es2015 files for distribution, it does not build the MatTable correctly. Tsickle sets its ctorParameters to an empty array which breaks ES6 usage (it should inject several things, seen in the CdkTable.

https://unpkg.com/@angular/material@5.2.5/esm2015/table.js

/** @nocollapse */
MatTable.ctorParameters = () => [];

Updating this version to fix this issue in the compiler for the next time we build. Although, technically we fixed it ourselves by working around it with an explicitly set constructor angular/components#10982.

@mary-poppins

Copy link
Copy Markdown

You can preview 1eef53e at https://pr23531-1eef53e.ngbuilds.io/.

@andrewseguin
andrewseguin force-pushed the compiler-cli-tsickle-update branch from 5f40aca to 1eef53e Compare May 1, 2018 17:34
@andrewseguin
andrewseguin requested a review from IgorMinar May 15, 2018 18:04
@ngbot

ngbot Bot commented May 16, 2018

Copy link
Copy Markdown

Hi @andrewseguin! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@scott-ho

Copy link
Copy Markdown

@andrewseguin why do you close the PR without further patches?

@andrewseguin

Copy link
Copy Markdown
Contributor Author

@scott-ho This change was captured by another PR, #23782

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants