Repository navigation
build(compiler-cli): update tsickle version - #23531
andrewseguin wants to merge 2 commits into
Conversation
|
You can preview c4dd049 at https://pr23531-c4dd049.ngbuilds.io/. |
|
what's the motivation for this change? are the previous patch versions broken in a significant way that would want us to ensure we are using the latest? something else? also if you don't update any lock files, we'll keep on using whatever we are currently using for our own tests, but since none of them are failing, it's really unclear what you are fixing, so more info would be appreciated. thanks! |
|
The version is being updated to include this fix in tsickle: angular/tsickle#760 The issue is that when Material builds its es2015 files for distribution, it does not build the https://unpkg.com/@angular/material@5.2.5/esm2015/table.js Updating this version to fix this issue in the compiler for the next time we build. Although, technically we fixed it ourselves by working around it with an explicitly set constructor angular/components#10982. |
|
You can preview 1eef53e at https://pr23531-1eef53e.ngbuilds.io/. |
5f40aca to
1eef53e
Compare
|
Hi @andrewseguin! This PR has merge conflicts due to recent upstream merges. |
|
@andrewseguin why do you close the PR without further patches? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Updating compiler-cli's tsickle version