Skip to content

build: update jasmine - #23230

Closed
alan-agius4 wants to merge 1 commit into
angular:masterfrom
alan-agius4:feature/update-jasmine
Closed

build: update jasmine#23230
alan-agius4 wants to merge 1 commit into
angular:masterfrom
alan-agius4:feature/update-jasmine

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Apr 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

Update jasmine, and jasmine-core in angular/angular

Tried to update everything throughout the whole project but had some errors. I will try to update this first than eventually try to update the rest when I have some more time.

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

This is due that with the current version tested it will cause false positive tests.

Relates to:
bazelbuild/rules_typescript#184
#23153

Example of error when nesting it with latest Jasmine

image

@gkalpak

gkalpak commented Apr 7, 2018

Copy link
Copy Markdown
Member

For reference, here is my previous attempt at upgradng jasmine and typings: #19904
It was quite more involved than just upgrading the npm packages 😁

It is quite bitrotten now, but may still have some useful pieces.

@alan-agius4

alan-agius4 commented Apr 7, 2018

Copy link
Copy Markdown
Contributor Author

Thanks buddy

@jasonaden jasonaden added the area: build & ci Related the build and CI infrastructure of the project label Apr 13, 2018
@rkirov rkirov mentioned this pull request May 16, 2018
Closed
@mhevery mhevery mentioned this pull request Jul 2, 2018
Closed
mhevery added a commit to mhevery/angular that referenced this pull request Jul 2, 2018
@mhevery
feat(core): upgrade to jasmine v3.1
d11c4fa 
Close angular#23230
Close angular#19904
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

area: build & ci Related the build and CI infrastructure of the project cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alan-agius4 @gkalpak @jasonaden @googlebot