Repository navigation
test(bazel): fix test for @angular/common ng_package - #23153
alan-agius4 wants to merge 2 commits into
Conversation
| shx.cd(path.join(process.env['TEST_SRCDIR'], 'angular', 'packages', 'common', 'npm_package')); | ||
|
|
||
| describe('@angular/common ng_package', () => { | ||
| it('should have the locales files', () => { |
There was a problem hiding this comment.
This is giving false positives :(
There was a problem hiding this comment.
you could make up for this mistake by writing a tslint or tsetse.info check so no one ever falls in this hole again. "the compiler could have caught it" is my mantra
There was a problem hiding this comment.
Thank you so much Alex, I’d give it a shoot and try to create a tsetse rule
|
Looks like ban-nested-jasmine-functions already covers this in tslint. It's
not as early as a compiler diagnostic, but it's a lot easier to just enable
this tslint check for angular/angular, want to try that?
…On Tue, Apr 3, 2018 at 2:15 PM Alan Agius ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In packages/bazel/test/ng_package/common_package.spec.ts
<#23153 (comment)>:
> @@ -13,15 +13,15 @@ import * as shx from 'shelljs';
shx.cd(path.join(process.env['TEST_SRCDIR'], 'angular', 'packages', 'common', 'npm_package'));
***@***.***/common ng_package', () => {
- it('should have the locales files', () => {
Thank you so much Alex, I’d give it a shoot and try to create a tsetse rule
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23153 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAC5I3uohwIlls-g2TCtEAFWx2RB97wPks5tk-ZbgaJpZM4TFtEL>
.
|
|
In which npm package Tried to google it but didn't yield any result for this rule either, maybe you can shed some light were you found it? |
|
Oops, that one is not open-source yet. +Bowen Ni <bowenni@google.com>
…On Wed, Apr 4, 2018 at 8:26 AM Alex Rickabaugh ***@***.***> wrote:
Closed #23153 <#23153> via 1678423
<1678423>
.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23153 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAC5I_MMq9QRf2oYbuvnwTUyiDGyva8gks5tlOYSgaJpZM4TFtEL>
.
|
|
Haha, I create a tsetse rule, if you prefer it instead of the tslint |
|
We need to document criteria like http://errorprone.info/docs/criteria
Would this qualify as an ERROR by those criteria? eg. you shouldn't even be
allowed to run a program that contains this mistake?
…On Wed, Apr 4, 2018 at 10:14 AM Alan Agius ***@***.***> wrote:
Haha, I create a tsetse rule, if you prefer it instead of the tslint
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23153 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC5I479XTbz8Tr4V9MCpRRUhsLb51fqks5tlP-NgaJpZM4TFtEL>
.
|
|
I think the above comment was meant was the following PR: bazelbuild/rules_typescript#184 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information