Skip to content

fix(aio): fix errors after RxJS 6 migration - #22886

Closed
cexbrayat wants to merge 1 commit into
angular:masterfrom
cexbrayat:fix/aio-import-error
Closed

fix(aio): fix errors after RxJS 6 migration #22886
cexbrayat wants to merge 1 commit into
angular:masterfrom
cexbrayat:fix/aio-import-error

Conversation

@cexbrayat

@cexbrayat cexbrayat commented Mar 20, 2018

Copy link
Copy Markdown
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

@IgorMinar PR #22573 introduced a few weird things

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@matsko matsko added area: core Issues related to the framework runtime comp: aio and removed area: core Issues related to the framework runtime labels Mar 22, 2018
@cexbrayat
cexbrayat force-pushed the fix/aio-import-error branch from 228aa4f to 537880c Compare April 18, 2018 06:25
@cexbrayat

cexbrayat commented Apr 18, 2018

Copy link
Copy Markdown
Member Author

Commit fe312cc from @brandonroberts fixed part of what this PR was covering, but there is still a slash remaining in an import after PR #22573 from @IgorMinar

@petebacondarwin petebacondarwin added the action: merge The PR is ready for merge by the caretaker label May 9, 2018
@ngbot

ngbot Bot commented May 9, 2018

Copy link
Copy Markdown

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure missing required label: "PR target: *"
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@petebacondarwin

petebacondarwin commented May 9, 2018

Copy link
Copy Markdown
Contributor

The Travis flake is not related to this PR.

@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label May 9, 2018
@IgorMinar IgorMinar closed this in e942d8b May 9, 2018
IgorMinar pushed a commit that referenced this pull request May 9, 2018
@cexbrayat @IgorMinar
fix(aio): fix error in import after RxJS 6 migration (#22886)
06776d1 
PR Close #22886
mashhoodr pushed a commit to mashhoodr/angular that referenced this pull request May 28, 2018
@cexbrayat @mashhoodr
fix(aio): fix error in import after RxJS 6 migration (angular#22886)
f598e21 
PR Close angular#22886
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@petebacondarwin petebacondarwin petebacondarwin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cexbrayat @petebacondarwin @matsko @IgorMinar @googlebot