Repository navigation
Conversation
Spread operator in this particular place was throwing off closure(probably because it was thrown off by the `of` in the source).
vikerman
added
the
action: review
|
You can preview fcb46cc at https://pr22870-fcb46cc.ngbuilds.io/. |
IgorMinar
suggested changes
Mar 19, 2018
IgorMinar
left a comment
IgorMinar
left a comment
Contributor
There was a problem hiding this comment.
In #22573 I rewrote this to:
+ return of (...waitHead, ...waitTail).pipe(concatAll(), lastValue(), map(() => res));
will this still be problematic? In the meantime I suggest we don't merge this as is. If needed I can cherry-pick this to my PR.
Contributor
|
I verified that this is no longer a problem with #22573. closing. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spread operator in this particular place was throwing off closure(probably because it was thrown off by the
ofin the source).PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current Angular code doesn't compile with certain closure compiler flag
What is the new behavior?
Works with closure
Does this PR introduce a breaking change?