Repository navigation
Conversation
kara
added
action: review
|
You can preview ee9035d at https://pr22690-ee9035d.ngbuilds.io/. |
mhevery
approved these changes
Mar 9, 2018
| * multiple `markForCheck` calls to into one change detection run. | ||
| * | ||
| * This can be used to ensure an OnPush component is checked when it needs to be re-rendered | ||
| * but the two normal triggers haven't marked it dirty (i.e. inputs haven't changed and events |
Contributor
There was a problem hiding this comment.
Could you make sure that this doc and https://github.com/angular/angular/blob/master/packages/core/src/change_detection/change_detector_ref.ts#L13-L38 match. Probably improve them both?
kara
removed
the
action: review
|
You can preview 0dc88dc at https://pr22690-0dc88dc.ngbuilds.io/. |
Contributor
Author
kara
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
ChangeDetectorRef.markForCheck.TODO in follow-up PRs:
checkNoChangesmarkForCheckwith dynamic views (waiting on bug fixes toViewContainerRef)