Repository navigation
Conversation
|
You can preview 888b55b at https://pr22669-888b55b.ngbuilds.io/. |
|
You can preview 589c2c8 at https://pr22669-589c2c8.ngbuilds.io/. |
|
You can preview 141d8a6 at https://pr22669-141d8a6.ngbuilds.io/. |
141d8a6 to
2114b20
Compare
|
You can preview 2114b20 at https://pr22669-2114b20.ngbuilds.io/. |
|
You can preview 2ea77b9 at https://pr22669-2ea77b9.ngbuilds.io/. |
|
You can preview a8b7a9d at https://pr22669-a8b7a9d.ngbuilds.io/. |
|
You can preview d3a99d8 at https://pr22669-d3a99d8.ngbuilds.io/. |
d3a99d8 to
2027ec8
Compare
|
You can preview 2027ec8 at https://pr22669-2027ec8.ngbuilds.io/. |
kara
added
type: bug/fix
area: build & ci
2027ec8 to
f47bace
Compare
|
You can preview f47bace at https://pr22669-f47bace.ngbuilds.io/. |
|
You can preview 5ede4a7 at https://pr22669-5ede4a7.ngbuilds.io/. |
|
You can preview 78a1998 at https://pr22669-78a1998.ngbuilds.io/. |
78a1998 to
0956037
Compare
|
You can preview 0956037 at https://pr22669-0956037.ngbuilds.io/. |
23ae723 to
780ca3e
Compare
|
You can preview 23ae723 at https://pr22669-23ae723.ngbuilds.io/. |
|
You can preview 780ca3e at https://pr22669-780ca3e.ngbuilds.io/. |
e9e4963 to
c4eca74
Compare
|
You can preview e9e4963 at https://pr22669-e9e4963.ngbuilds.io/. |
|
You can preview c4eca74 at https://pr22669-c4eca74.ngbuilds.io/. |
c4eca74 to
783eb01
Compare
|
You can preview 783eb01 at https://pr22669-783eb01.ngbuilds.io/. |
|
Caretaker note: TAP is now passing but I can't push the commit status to this PR right now! https://test.corp.google.com/ui#id=OCL:188670023:BASE:188670926:1520822633851:ceb2701a |
| if (typeof blockFn === 'function') { | ||
| document.body.innerHTML = html; | ||
| let blockReturn = blockFn(); | ||
| // TODO(i): I'm not sure why a cast is required here but otherwise I get |
There was a problem hiding this comment.
do you mean to replace (i) with something else?
|
|
||
| constructor(input: string|Request, init: RequestInit = {}) { | ||
| super(init !== undefined ? init.body || null : null); | ||
| super(init !== undefined ? (init.body as(string | null)) || null : null); |
There was a problem hiding this comment.
do some of these casts need TODOs?
There was a problem hiding this comment.
I think the casts to any should be eventually removed, but I'd rather add a tslint rule to fend those off than more todos.
| * Factory method used to create an instance of directive. | ||
| */ | ||
| factory: () => T | [T]; | ||
| factory: () => T | ({0: T} & any[]); /* trying to say T | [T, ...any] */ |
IgorMinar
added
action: merge
This is not expected to be a breaking change for anyone who's on Node LTS (currently v8) and aligns @angular/compilar-cli with @angular/cli's runtime requirements. PR Close #22669
This enables us to minify ES2015 code. PR Close #22669
…en for older tsc versions (#22669) Previously the flag would only disable the check in the case we tried to use newer tsc version. In g3 we sometimes take a while to update tsc, but as a prerequisite of that Angular needs to be updated first. This change enables us to update Angular and use it in g3 while g3 is being update to the required tsc. Of course extra care is required when this check is disabled, but since we control everything in g3, it's on us to get this right. I don't see any preexisting tests for this, and I'm not sure how to write them right now. I filed #22699 PR Close #22669
…in output after TS 2.7 update in angular#22669
…change in output after TS 2.7 update in angular#22669
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes: #21571
Closes: #22097