Skip to content

feat(router): add routing to async components#2165

Closed
btford wants to merge 2 commits into
angular:masterfrom
btford:feat-async-recognition
Closed

feat(router): add routing to async components#2165
btford wants to merge 2 commits into
angular:masterfrom
btford:feat-async-recognition

Conversation

@btford

@btford btford commented May 26, 2015

Copy link
Copy Markdown
Contributor

This lays the groundwork for lazy loading in Angular 2.

I'm still working on the API + Docs.

@mhevery

mhevery commented May 28, 2015

Copy link
Copy Markdown
Contributor

@IgorMinar please review

@btford btford added this to the M9: TypeScript and Build Stability milestone May 28, 2015
@mhevery mhevery modified the milestone: M9: TypeScript and Build Stability May 29, 2015
@btford

btford commented May 29, 2015

Copy link
Copy Markdown
Contributor Author

We're going to prioritize #2001 over this, so hold off until after the router is typescriptified since I'll have to rewrite/rebase this.

@btford btford mentioned this pull request May 29, 2015
@tbosch tbosch added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 1, 2015
@btford
btford force-pushed the feat-async-recognition branch 2 times, most recently from 257905c to ebb5bba Compare June 8, 2015 20:59
Note that this also removes the `components` option from `RouteConfig`.
This functionality will be reintroduced with the more general `//` routing.
See angular#2329 for more details.
@btford
btford force-pushed the feat-async-recognition branch from ebb5bba to e552080 Compare June 8, 2015 21:15
@btford

btford commented Jun 8, 2015

Copy link
Copy Markdown
Contributor Author

Landed as 548f3dd and cd95e07.

@btford btford closed this Jun 8, 2015
@jpsfs

jpsfs commented Jul 20, 2015

Copy link
Copy Markdown

Hi,

Sorry to dig up this.

I'm doing some experiences with routing and lazy loaded components. Right now the only examples I'm seeing require something like:

´´´
import {MyComponent} from "mypackage";

@RouteConfig([
{ path: '/', component: MyComponent, as 'start'}
])
´´´

Now, what I don't want to load MyComponent until I absolutely need to. Is there any way of doing something like:

´´´
@RouteConfig([
{ path: '/', component: 'mypackage/MyComponent', as 'start'}
])
´´´

Cheers,

@btford
btford deleted the feat-async-recognition branch October 23, 2015 13:04
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants