Skip to content

fix(compiler-cli): use the oldProgram option in watch mode - #21364

Closed
alippai wants to merge 1 commit into
angular:masterfrom
alippai:patch-1
Closed

fix(compiler-cli): use the oldProgram option in watch mode#21364
alippai wants to merge 1 commit into
angular:masterfrom
alippai:patch-1

Conversation

@alippai

@alippai alippai commented Jan 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

The performCompilation() is always called with an undefined oldProgram option (even in watch mode).
This was regression introduced in: 957be96

Partial fix, discovered in: #21361

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@alippai alippai changed the title fix(compiler-cli): Use the oldProgram option in watch mode fix(compiler-cli): use the oldProgram option in watch mode Jan 7, 2018
@ocombe ocombe added the area: core Issues related to the framework runtime label Jan 8, 2018
@mhevery

mhevery commented Jan 16, 2018

Copy link
Copy Markdown
Contributor

@chuckjaz can you review and approve? Can this have test?

@alippai

alippai commented Apr 17, 2018

Copy link
Copy Markdown
Contributor Author

@mhevery can I help somehow, so you don't ship Angular 6.0 with incremental building disabled?

@alippai

alippai commented May 22, 2018

Copy link
Copy Markdown
Contributor Author

This is a single variable name typo. How can I make progress?

@alippai

alippai commented Jul 12, 2018

Copy link
Copy Markdown
Contributor Author

With TS 2.8 and Angular 6.1-beta this introduces a new bug now

@mhevery
mhevery requested a review from alxhub July 27, 2018 22:24
@alippai

alippai commented Jul 28, 2018

Copy link
Copy Markdown
Contributor Author

@alexhub let me double check this tomorrow with TS 2.9 and Angular 6.1.0

@alippai Adam Lippai
fix(compiler-cli): use the oldProgram option in watch mode
66ea4c4 
The performCompilation() is always called with an undefined oldProgram option (even in watch mode).
This was regression introduced in: angular@957be96

Partial fix, discovered in: angular#21361
@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Aug 7, 2018
@mhevery

mhevery commented Aug 7, 2018

Copy link
Copy Markdown
Contributor

http://test/OCL:207747848:BASE:207747871:1533665655598:e7bbbdf9

@kara kara closed this in c6e5b97 Aug 7, 2018
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alippai @mhevery @alxhub @ocombe @googlebot