Repository navigation
fix(compiler): report an error for recursive module references - #21054
Merged
Merged
Conversation
vicb
reviewed
Dec 18, 2017
Modules that directly or indirectly export or imported themselves reports an error instead of generating a stack fault. Fixes: angular#19979
vicb
approved these changes
Dec 18, 2017
vicb
left a comment
vicb
left a comment
Contributor
There was a problem hiding this comment.
LGTM, one nit for test name
mhevery
approved these changes
Dec 19, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modules that directly or indirectly export or imported themselves
reports an error instead of generating a stack fault.
Fixes: #19979
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #19979
See commit description above.
What is the new behavior?
An error is emitted instead of a stack fault.
Does this PR introduce a breaking change?