Skip to content

docs(aio): update myUnless references to appUnless - #20658

Closed
hartraft wants to merge 1 commit into
angular:masterfrom
hartraft:patch-1
Closed

docs(aio): update myUnless references to appUnless#20658
hartraft wants to merge 1 commit into
angular:masterfrom
hartraft:patch-1

Conversation

@hartraft

@hartraft hartraft commented Nov 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes Issue Number: #20447

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

myUnless is referenced in the documentation where appUnless is shown in code examples

Issue Number: #20447

What is the new behavior?

appUnless is referenced in the aio docs

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@kapunahelewong

kapunahelewong commented Nov 28, 2017

Copy link
Copy Markdown
Contributor

@hartraft You even did the e2e tests! Thanks!

@gkalpak LGTM, is there anything else I should do to help this along?

gkalpak
gkalpak suggested changes Nov 28, 2017
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of minor comments.
Can you also squash the commits together?

Comment thread aio/content/guide/structural-directives.md Outdated

@gkalpak gkalpak Nov 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a --> an

Comment thread aio/content/guide/structural-directives.md Outdated

@gkalpak gkalpak Nov 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but while you are at it, feel free to fix the double-space 😁

@hartraft

hartraft commented Nov 29, 2017

Copy link
Copy Markdown
Contributor Author

@gkalpak thanks for reviewing the PR! I've made the changes needed 😃

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 30, 2017
@gkalpak

gkalpak commented Nov 30, 2017

Copy link
Copy Markdown
Member

The Travis failures are not related to this PR. ("Inherited" from master.)

IgorMinar pushed a commit that referenced this pull request Dec 6, 2017
@hartraft @IgorMinar
docs(aio): update myUnless references to appUnless (#20658)
860ef8c 
fixes Issue Number: #20447

PR Close #20658
@IgorMinar IgorMinar closed this in 77ef527 Dec 6, 2017
@gkalpak gkalpak mentioned this pull request Dec 6, 2017
Closed
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@kapunahelewong kapunahelewong kapunahelewong approved these changes
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kapunahelewong kapunahelewong

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hartraft @kapunahelewong @gkalpak @googlebot