Skip to content

build(aio): upgrade to codelyzer(4.0.x) - #20392

Closed
akkumar wants to merge 1 commit into
angular:masterfrom
akkumar:codelyzer4_ng5
Closed

build(aio): upgrade to codelyzer(4.0.x)#20392
akkumar wants to merge 1 commit into
angular:masterfrom
akkumar:codelyzer4_ng5

Conversation

@akkumar

@akkumar akkumar commented Nov 13, 2017 •
edited
Loading

Copy link
Copy Markdown

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

Upgrades the boilerplate sample in cli to be codelyzer 4.0.0 instead of 3.2.x.

What is the current behavior?

Currently it is at

    "codelyzer": "~3.2.0",

Issue Number: angular/angular-cli#8463

What is the new behavior?

codelyzer for ng5 should refer to ~4.0.1
Currently it is at

    "codelyzer": "^4.0.1",

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

More details at - https://github.com/mgechev/codelyzer/blob/master/CHANGELOG.md#400 .

gkalpak
gkalpak reviewed Nov 13, 2017
View reviewed changes
Comment thread aio/tools/examples/shared/boilerplate/cli/package.json Outdated

@gkalpak gkalpak Nov 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is supposed to mirror what the @angular/cli would generate and right now, it would generate ~3.2.0, so I think it is best to leave it at that.

@akkumar akkumar Nov 13, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkalpak - Thanks for pointing to the right source of truth. angular/devkit#272 logged independently to address the same.

We can visit this later after the source of truth in devkit is addressed. Thanks !

@akkumar akkumar Nov 14, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

angular/devkit#253 and angular/devkit#257 under discussion for the same issue as well. FYI

@akkumar akkumar Nov 23, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

angular/devkit#257 commit - angular/devkit@3a620e2 is now in, making codelyzer at 4.0.1

So - now may this issue can be merged as well , @gkalpak ?

@gkalpak gkalpak Nov 23, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angular/cli is still at 1.5.0 in this package.json (and the merged PR hasn't been released yet afaict), so we con't merge it. To fix it in the examples, we need to upgrade the @angular/cli dependency and the rest of package.json to match what would have been generated with the cli.

@akkumar akkumar Nov 25, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angular/cli 1.5.4 contains the fix for commit under discussion ( to ugprade codelyzer to 4.0.1 by default).

$ cat package.json | grep codelyzer
    "codelyzer": "^4.0.1",
 $ ng version
Angular CLI: 1.5.4

upgrading angular/cli to 1.5.4 as well in this package.json to reflect the change, hence.

@gkalpak gkalpak added aio: preview action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 13, 2017
@mary-poppins

mary-poppins commented Nov 13, 2017

Copy link
Copy Markdown

You can preview 59ddcaf at https://pr20392-59ddcaf.ngbuilds.io/.

@mary-poppins

mary-poppins commented Nov 13, 2017

Copy link
Copy Markdown

You can preview ff68f88 at https://pr20392-ff68f88.ngbuilds.io/.

@akkumar akkumar mentioned this pull request Nov 13, 2017
Closed
@mary-poppins

mary-poppins commented Nov 23, 2017

Copy link
Copy Markdown

You can preview 316162a at https://pr20392-316162a.ngbuilds.io/.

@mary-poppins

mary-poppins commented Nov 23, 2017

Copy link
Copy Markdown

You can preview 3644fd5 at https://pr20392-3644fd5.ngbuilds.io/.

@akkumar akkumar changed the title build(aio): upgrade to codelyzer(4.0) build(aio): upgrade to codelyzer(4.0.x) Nov 23, 2017
@mary-poppins

mary-poppins commented Nov 25, 2017

Copy link
Copy Markdown

You can preview d788cb8 at https://pr20392-d788cb8.ngbuilds.io/.

@mary-poppins

mary-poppins commented Nov 25, 2017

Copy link
Copy Markdown

You can preview 91c7091 at https://pr20392-91c7091.ngbuilds.io/.

@akkumar

akkumar commented Nov 25, 2017 •
edited
Loading

Copy link
Copy Markdown
Author

Did a force commit and lost the previous conversation history here (associated with one of the earlier commits).

summary: angular/cli 1.5.4 (includes the recent commit to angular/devkit upgrading codelyzer to 4.0.1 ) released recently contains codelyzer ^4.0.1 by default as intended. So upgrading angular/cli and codelyzer as appropriate in the package.json .

cc @gkalpak

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 28, 2017
@mhevery mhevery closed this in 0bef021 Nov 29, 2017
mhevery pushed a commit that referenced this pull request Nov 29, 2017
Karthik Kumar A @mhevery
build(aio): upgrade codelyzer to 4.0.x and angular/cli to 1.5.4 (#20392)
108b6e7 
PR Close #20392
@akkumar
akkumar deleted the codelyzer4_ng5 branch December 1, 2017 07:34
wKoza pushed a commit to wKoza/angular that referenced this pull request Dec 2, 2017
Karthik Kumar A @wKoza
build(aio): upgrade codelyzer to 4.0.x and angular/cli to 1.5.4 (angu…
ce8905e 
…lar#20392)

PR Close angular#20392
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@akkumar @mary-poppins @gkalpak @jasonaden @googlebot