Skip to content

fix(forms): disable radio inputs in template driven forms - #20310

Closed
mohamed-gara wants to merge 1 commit into
angular:masterfrom
mohamed-gara:18206_The_disabled_binding_does_not_work_for_multiple_radio_inputs
Closed

mohamed-gara wants to merge 1 commit into
angular:masterfrom
mohamed-gara:18206_The_disabled_binding_does_not_work_for_multiple_radio_inputs

Conversation

@mohamed-gara

Copy link
Copy Markdown

In template driven forms, disable radio controls when they are initially disabled using data binding.

closes #18206

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

#18206

Issue Number: 18206

What is the new behavior?

In template driven forms, the radio inputs are correctly disabled when they are initially disabled using data binding.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

In template driven forms, disable radio controls when they are initially disabled using data binding.

closes angular#18206
@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer type: bug/fix labels Nov 30, 2017
@jasonaden jasonaden added this to the needsTriage milestone Jan 29, 2019
@AndrewKushnir

Copy link
Copy Markdown
Contributor

Hi, it looks like this fix is very similar to the one in #35311, so I'll close this PR in favor of #35311. The mentioned PR will have a link to this PR in case some parts of this PR can be reused in #35311. Thank you.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: forms cla: yes type: bug/fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The [disabled] binding does not work for multiple radio inputs

5 participants