Skip to content

docs(aio): update myHighlight references to appHighlight - #20233

Closed
hartraft wants to merge 3 commits into
angular:masterfrom
hartraft:update-appHighlight-references
Closed

docs(aio): update myHighlight references to appHighlight#20233
hartraft wants to merge 3 commits into
angular:masterfrom
hartraft:update-appHighlight-references

Conversation

@hartraft

@hartraft hartraft commented Nov 7, 2017

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
Fix documentation on referenced attribute directive appHighlight

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In Angular.io docs, myHighlight is referenced in Attribute Directives and Dependency Injection In Action. In the code snippets, appHighlight is mentioned.

Issue Number: N/A

What is the new behavior?

appHighlight is mentioned where myHighlight was.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@trotyl

trotyl commented Nov 7, 2017

Copy link
Copy Markdown
Contributor

Partially duplicate of #19778 in aio/content/guide/dependency-injection-in-action.md, likely to be a failure in #19778 for omitting the other parts.

But should be fine to keep #19778 as is and fix the conflict here after #19778 merges.

@vicb vicb added the comp: aio label Nov 8, 2017
@ngbot

ngbot Bot commented Jan 16, 2018

Copy link
Copy Markdown

Hello? Don't want to hassle you. Sure you're busy. But this PR has some merge conflicts that you probably ought to resolve.
That is... if you want it to be merged someday...

1 similar comment
@ngbot

ngbot Bot commented Jan 16, 2018

Copy link
Copy Markdown

Hello? Don't want to hassle you. Sure you're busy. But this PR has some merge conflicts that you probably ought to resolve.
That is... if you want it to be merged someday...

@hartraft
docs(aio): update myHighlight references to appHighlight
24bc586
@hartraft
Merge remote-tracking branch 'origin/update-appHighlight-references' …
472f946 
…into update-appHighlight-references

# Conflicts:
#	aio/content/guide/attribute-directives.md
@jenniferfell jenniferfell added state: community Someone from the Angular community is working on this issue or submitted this PR and removed state: community Someone from the Angular community is working on this issue or submitted this PR labels Jul 23, 2018
@brandonroberts

brandonroberts commented Aug 2, 2018

Copy link
Copy Markdown
Contributor

Closing as no longer applicable

@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@odykyi odykyi odykyi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@hartraft @trotyl @brandonroberts @odykyi @vicb @googlebot @gkalpak @jenniferfell