Skip to content

Improve AOT unit tests - #20224

Closed
vicb wants to merge 3 commits into
angular:masterfrom
vicb:gh-19996
Closed

vicb wants to merge 3 commits into
angular:masterfrom
vicb:gh-19996

Conversation

@vicb

@vicb vicb commented Nov 6, 2017

Copy link
Copy Markdown
Contributor

Supersedes #19996

@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

…TestingModule`

Also adds caching for summaries.

Closes angular#19817.
This allows to overwrite templates for JIT and AOT components alike.

In contrast to `TestBed.overrideTemplate`, the template is compiled
in the context of the testing module, allowing to use other testing
directives.

Closes angular#19815
@vicb vicb added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 6, 2017
@vicb

vicb commented Nov 6, 2017

Copy link
Copy Markdown
Contributor Author

The original PR was approved.
CLA is "no" because the 2 first commits are from Tobias.

@mary-poppins

Copy link
Copy Markdown

You can preview b62752d at https://pr20224-b62752d.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview fc7aff8 at https://pr20224-fc7aff8.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview 99c4a1b at https://pr20224-99c4a1b.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview 817d086 at https://pr20224-817d086.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview fccddae at https://pr20224-fccddae.ngbuilds.io/.

@vicb

vicb commented Nov 6, 2017

Copy link
Copy Markdown
Contributor Author

The test fails because of the increased payload for the testing bundle.
I'll merge anyway to unblock g3.
@tinayuangao please follow up. thanks.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: no

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants