build(aio): migrate plunker to stackblitz by Foxandxss · Pull Request #20165 · angular/angular

Foxandxss · 2017-11-03T18:06:24Z

Stackblitz support for the AIO docs.

Should be complete, but I am sure I am missing a tiny bit or something.

ISSUES:

There is a chunk of code at live-example.component.ts that deals with narrowScreens that won't work with this update but I require someone that knows more about it to fix it.
Testing chapter has some plunkers that needs systemjs but I remember Ward wanting to remove them in a upcoming testing chapter upgrade.

mary-poppins · 2017-11-03T19:04:10Z

You can preview 79edb73 at https://pr20165-79edb73.ngbuilds.io/.

EricSimons · 2017-11-03T20:06:33Z

Wow, that was fast! Awesome job @Foxandxss! 💯

On our end, we should be 100% ready to rock&roll by the end of next week - just have a few remaining pieces of func & perf improvements to finish up 👍 Specifically, we'll be rolling out:

Hydrate dependencies/type definitions on page load to ensure the preview boots in <=4 secs (currently can hang for a long time bc the browser has to download hundreds of d.ts files individually from unpkg)
- Note: We currently do this for regular stackblitz projects automatically, but since these projects are generated on demand via the API we just need to tweak our architecture a bit to accommodate
Deploy HyperBoot, our new in-browser dev server, to prod. This will increase bundling & boot performance by >5x
Upgraded mobile & embed views
Various last mile fixes
- Enable "forking" functionality for these projects
- Ensure "export" functionality works as intended
- UI upgrades

Also, in regards to uptime reliability, we've intentionally designed our architecture to scale gracefully & horizontally. Specifically, we're powering the API endpoint all examples hit w/ a lambda that's decoupled from stackblitz's core app servers & the example projects themselves are stored/cached in redis. This ensures all traffic to the examples will be in-memory cache hits, avoiding any potential DB bottlenecks on the app server. Our core app servers are also load balanced & on auto-scale, should traffic ever get super crazy 👍

petebacondarwin · 2017-11-03T22:15:46Z

@Foxandxss - it would be useful to rebase off the current master. There are conflicts

Foxandxss · 2017-11-03T22:17:48Z

Yes, I was waiting for more merges, that will bring possibly more conflicts.

Toxicable · 2017-11-04T07:55:53Z

this will close #20045

petebacondarwin · 2017-11-12T08:00:50Z

We are showing holding images for embedded examples (e.g. https://pr20165-79edb73.ngbuilds.io/guide/ngmodule#compile-just-in-time-jit) but the holding image is still generated from Plunker.

We need to replace all of these images across the codebase. Ideally, we should either not bother with these images (was it a performance thing?) or find some way to generate them as part of the doc-gen.

petebacondarwin · 2017-11-12T08:37:59Z

@EricSimons: Is it possible to get StackBlitz to provide a URL that will result in a download of a zip file? This would allow us to remove our own zip generation and download functionality.

petebacondarwin · 2017-11-03T18:44:35Z

How about we switch "plunker" for something more generic, like "online" or something?

Or simply "live-example"

In that concrete use case, I agree.

gkalpak

Feels good to see all that SystemJS-specific code go 😃

A couple of questions/suggestions:

In order for the ServiceWorker to route the stackblitz URLs correctly, you need to update this RegExp.
It would be nice if we could replace "stackblitz" with something generic (such as "live-example") whenever possible.

gkalpak · 2017-11-13T14:07:33Z

I would change this to something more descriptive (e.g. activeFile).

Stackblitz API expects a "file" so its better not to rename it locally.

gkalpak · 2017-11-13T14:31:19Z

main --> file

Oh, it was intentional? What is main used for?

Which file to use as the "index.html". So by default it will pick the index.html but if you have a different one, say index.1b.html then you set it to be the main one. This is not stackblitz, this is how we developed the tool in the first place.

gkalpak · 2017-11-13T14:31:41Z

main --> file

gkalpak · 2017-11-13T14:32:08Z

main --> file

gkalpak · 2017-11-13T15:15:30Z

main --> file (here and elsewhere)

gkalpak · 2017-11-13T18:03:25Z

stackblitz --> plunkrs (or live examples) 😃

gkalpak · 2017-11-13T18:04:22Z

Woohoo 🎉
Aren't there more SystemJS-related files that we can remove now?

Probably not. We will see. I will do a cleanup PR soon.

gkalpak · 2017-11-13T18:11:41Z

This comment doesn't seem to describe what is happening below 😕

Actually it does, but I am tweaking the comment a bit.

gkalpak · 2017-11-13T18:13:25Z

What a beautiful regex 😛
What about other references to the main.X.ts file? I remember seeing one inside an index.html (System.import('...')).

That shouldn't be the case anymore

gkalpak · 2017-11-13T18:15:06Z

return fileName 😃

EricSimons · 2017-11-20T19:01:10Z

As mentioned in the slack channel, we're changing the API url later today from

https://run.stackblitz.com/api/aio/v1

to

https://run.stackblitz.com/api/angular/v1

per request of the Ang Material folks. We'll add in a redirect from the aio->angular url so that nothing breaks, but the url should prob be updated to the new one before merging this PR into master 👍

petebacondarwin · 2017-11-20T19:57:41Z

@Foxandxss we should really land this PR in the next few days. Do you have time to work on it or shall we bump it to someone else?

Foxandxss · 2017-11-20T20:02:40Z

Ill give it love at Wed morning. Tomorrow I am out giving a course.

EricSimons · 2017-11-22T02:32:36Z

New endpoint URL (https://run.stackblitz.com/api/angular/v1) is now on prod! 👍

Foxandxss · 2017-11-22T12:08:26Z

Addressed some of the comments. The preview images on embedded are waiting for @wardbell to do them.

mary-poppins · 2017-11-22T12:16:22Z

You can preview c2c47c3 at https://pr20165-c2c47c3.ngbuilds.io/.

mary-poppins · 2017-11-23T20:21:50Z

You can preview eeec1eb at https://pr20165-eeec1eb.ngbuilds.io/.

gkalpak

I didn't go through all the files again, but did check changes related to my previous comments.

Generally LGTM 👍 ❤️ 🎉

There are a couple of things, which are still missing (afaik) and I wouldn't ship this change without:

In order for the ServiceWorker to route the stackblitz URLs correctly, you need to update this RegExp.
We need to update testing to work on stackblitz too.
The placeholder images need to be updated (maybe to something generic).

_{It still think it would be nice if we could replace "stackblitz" with something generic (such as "live-example") whenever possible, but happy to leave it for a future PR (if at all) 😃}

petebacondarwin · 2017-11-24T12:30:27Z

replace "stackblitz" with something generic

+1 (but happy for that to go in another PR)

Foxandxss · 2017-11-29T18:54:21Z

Only the image is needed (waiting for @wardbell). Current testing is quite broken, this PR won't fix it so it will be fixed in a different PR.

mary-poppins · 2017-11-29T18:59:51Z

You can preview 34229ea at https://pr20165-34229ea.ngbuilds.io/.

gkalpak · 2017-11-29T21:12:23Z

Service worker routing is fixed.
Testing is already broken (on plnkr as well), so happy to defer to a different PR (already in progress: docs: testing guide for CLI #20697).
The image is still missing. Fine by me to get it in on a follow-up PR right after this gets merged.

Assigning to @IgorMinar to add the merge label when we are ready to make the switch (both from a technical and non-technical point of view 😃).

mary-poppins · 2017-11-29T21:43:01Z

You can preview 4cd9b3b at https://pr20165-4cd9b3b.ngbuilds.io/.

gkalpak

The image is too big. It doesn't look nice for certain screen widths:

Also, the "Click to run" thingy looks like it is part of the demo app. I am not sure I woud realize I am supposed to click that to run the example.
_{(Maybe it's just me.)}

Also, remove `plnkr.json` for `service-worker-getting-started` guide, since it is not used and ServiceWorker cannot work correctly in plnkr/stackblitz anyway (e.g. no build step to re-compute hashes). A zipper might be useful and can be added in a subsequent PR, but it is currently broken (e.g. no dependency on `@angular/service-worker`).

ngbot · 2018-01-24T00:44:16Z

I see that you just added the PR action: merge label, but the following checks are still failing:
     missing required status "code-review/pullapprove"
     status "ci/circleci: lint" is pending
     status "ci/circleci: build" is pending
     status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

mary-poppins · 2018-01-24T01:01:24Z

You can preview c604804 at https://pr20165-c604804.ngbuilds.io/.

mhevery · 2018-01-24T01:10:44Z

http://test/OCL:183017368:BASE:183017465:1516756183390:3ec6ff57

PR Close #20165

…0165) - Update tooling to support revised testing guide (PR #20697). - Require jasmine upgrade for examples that use marble testing. - Copy `cli/package.json` to `testing/` and add `jasmine-marbles`. - Resolve merge conflicts created by `NgModules` guides. PR Close #20165

…20165) Also, remove `plnkr.json` for `service-worker-getting-started` guide, since it is not used and ServiceWorker cannot work correctly in plnkr/stackblitz anyway (e.g. no build step to re-compute hashes). A zipper might be useful and can be added in a subsequent PR, but it is currently broken (e.g. no dependency on `@angular/service-worker`). PR Close #20165

PR Close #20165

…0165) - Update tooling to support revised testing guide (PR #20697). - Require jasmine upgrade for examples that use marble testing. - Copy `cli/package.json` to `testing/` and add `jasmine-marbles`. - Resolve merge conflicts created by `NgModules` guides. PR Close #20165

…20165) Also, remove `plnkr.json` for `service-worker-getting-started` guide, since it is not used and ServiceWorker cannot work correctly in plnkr/stackblitz anyway (e.g. no build step to re-compute hashes). A zipper might be useful and can be added in a subsequent PR, but it is currently broken (e.g. no dependency on `@angular/service-worker`). PR Close #20165

PR Close #20165

IgorMinar · 2018-01-24T16:37:08Z

This is now live. Thank you everyone who made this happen!!! 🎉 🎈 🎆

angular-automatic-lock-bot · 2019-09-13T05:22:46Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Foxandxss added the comp: aio label Nov 3, 2017

googlebot added the cla: yes label Nov 3, 2017

petebacondarwin reviewed Nov 12, 2017

View reviewed changes

ocombe added the target: patch This PR is targeted for the next patch release label Nov 13, 2017

gkalpak reviewed Nov 13, 2017

View reviewed changes

Foxandxss force-pushed the aio-stackblitz branch from 79edb73 to e56d61c Compare November 22, 2017 11:41

gkalpak suggested changes Nov 24, 2017

View reviewed changes

petebacondarwin mentioned this pull request Nov 28, 2017

docs(aio): document updateOn blur in validation guide #18519

Closed

gkalpak approved these changes Nov 29, 2017

View reviewed changes

gkalpak assigned IgorMinar Nov 29, 2017

gkalpak suggested changes Nov 30, 2017

View reviewed changes

gkalpak added 2 commits January 23, 2018 16:32

fix(aio): remove remaining plnkr references

c604804

IgorMinar force-pushed the aio-stackblitz branch from 2867179 to c604804 Compare January 24, 2018 00:44

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: discuss labels Jan 24, 2018

mhevery pushed a commit that referenced this pull request Jan 24, 2018

build(aio): migrate plunker to stackblitz (#20165)

0cbccc0

PR Close #20165

mhevery pushed a commit that referenced this pull request Jan 24, 2018

fix(aio): remove remaining plnkr references (#20165)

2f61d3c

PR Close #20165

mhevery closed this in 1a75934 Jan 24, 2018

mhevery pushed a commit that referenced this pull request Jan 24, 2018

fix(aio): remove remaining plnkr references (#20165)

d0e086a

PR Close #20165

Foxandxss deleted the aio-stackblitz branch January 24, 2018 11:56

gkalpak mentioned this pull request Feb 2, 2018

feature request(docs): migrate plunkr examples to StackBlitz #20045

Closed

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019

Conversation

Foxandxss commented Nov 3, 2017

Uh oh!

mary-poppins commented Nov 3, 2017

Uh oh!

EricSimons commented Nov 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petebacondarwin commented Nov 3, 2017

Uh oh!

Foxandxss commented Nov 3, 2017

Uh oh!

Toxicable commented Nov 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petebacondarwin commented Nov 12, 2017

Uh oh!

petebacondarwin commented Nov 12, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EricSimons commented Nov 20, 2017

Uh oh!

petebacondarwin commented Nov 20, 2017

Uh oh!

Foxandxss commented Nov 20, 2017

Uh oh!

EricSimons commented Nov 22, 2017

Uh oh!

Foxandxss commented Nov 22, 2017

Uh oh!

mary-poppins commented Nov 22, 2017

Uh oh!

mary-poppins commented Nov 23, 2017

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin commented Nov 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

EricSimons commented Nov 3, 2017 •

edited

Loading

Toxicable commented Nov 4, 2017 •

edited

Loading

petebacondarwin commented Nov 24, 2017 •

edited

Loading

gkalpak left a comment •

edited

Loading