docs: Update router guide to use Angular CLI by brandonroberts · Pull Request #20023 · angular/angular

brandonroberts · 2017-10-30T16:33:37Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Cleans up many issues with the guide

Conforms to Angular CLI structure w/generation commands
Cleans up Getting Started milestone
Adds complete list of router events
Cleans up milestone instructions
Adds section on routable animations
Various other fixes

Closes #17778, #18538, #19443, #21174, #23659, #23900, #24638, #17794

mary-poppins · 2017-10-30T16:45:04Z

You can preview ac326d8 at https://pr20023-ac326d8.ngbuilds.io/.

petebacondarwin · 2017-11-29T18:06:14Z

No changes to the AIO app or tooling - so removed the comp: aio label.

IgorMinar · 2018-03-09T04:09:16Z

@jasonaden @jenniferfell this looks like a valuable change. can we schedule this for a review some time in the next sprint or so? thanks

IgorMinar · 2018-03-09T04:10:12Z

@brandonroberts could you please rebase this change after we cut 6.0.0-rc.0 - don't bother doing it sooner, we are landing some cross-repo refactoring that will likely create conflicts.

mary-poppins · 2018-03-09T04:27:38Z

You can preview eb23253 at https://pr20023-eb23253.ngbuilds.io/.

brandonroberts · 2018-03-09T04:31:31Z

Sure @IgorMinar. Thanks for circling back on these changes to the guide.

ngbot · 2018-03-19T23:38:33Z

Hi @brandonroberts! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

mary-poppins · 2018-04-04T15:10:28Z

You can preview bd5d5b3 at https://pr20023-bd5d5b3.ngbuilds.io/.

ngbot · 2018-04-04T15:27:11Z

Hi @brandonroberts! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

brandonroberts · 2018-04-04T15:30:14Z

@IgorMinar this branch has been rebased off the latest RC

mary-poppins · 2018-04-04T16:14:58Z

You can preview fa1db19 at https://pr20023-fa1db19.ngbuilds.io/.

mary-poppins · 2018-04-04T16:43:59Z

You can preview 4ce1479 at https://pr20023-4ce1479.ngbuilds.io/.

ngbot · 2018-04-27T14:24:25Z

Hi @brandonroberts! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

PR Close #20023

angular-automatic-lock-bot · 2019-09-14T02:21:37Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 30, 2017

brandonroberts mentioned this pull request Nov 13, 2017

docs(aio): Refresh content on routable animations for router guide #19630

Closed

1 of 3 tasks

jasonaden added the comp: aio label Nov 14, 2017

gkalpak added the comp: docs label Nov 28, 2017

petebacondarwin removed the comp: aio label Nov 29, 2017

IgorMinar added area: router action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 9, 2018

brandonroberts force-pushed the router-cli branch from ac326d8 to eb23253 Compare March 9, 2018 04:19

brandonroberts force-pushed the router-cli branch 3 times, most recently from bd5d5b3 to 903dace Compare April 4, 2018 15:03

brandonroberts force-pushed the router-cli branch from 903dace to fa1db19 Compare April 4, 2018 15:26

brandonroberts force-pushed the router-cli branch from fa1db19 to 4ce1479 Compare April 4, 2018 16:21

jenniferfell added this to the v6-candidates milestone Apr 25, 2018

jenniferfell mentioned this pull request Apr 25, 2018

List of updates needed for CLI docs #19510

Closed

21 of 24 tasks

brandonroberts force-pushed the router-cli branch from 4ce1479 to cdeecda Compare April 29, 2018 23:27

jenniferfell removed this from the v6-candidates milestone May 2, 2018

kara pushed a commit that referenced this pull request Sep 26, 2018

docs: router guide review feedback changes (#20023)

ac5aa8f

PR Close #20023

kara pushed a commit that referenced this pull request Sep 26, 2018

docs: clean up providedIn: 'root' syntax for router examples (#20023)

0aafbac

PR Close #20023

kara pushed a commit that referenced this pull request Sep 26, 2018

docs: add section on router integration (#20023)

a5b7008

PR Close #20023

kara pushed a commit that referenced this pull request Sep 26, 2018

docs: update routing integration section based on feedback (#20023)

bc88f31

PR Close #20023

kara pushed a commit that referenced this pull request Sep 26, 2018

docs: Refresh content on routable animations for router guide (#20023)

c9fece9

PR Close #20023

kara pushed a commit that referenced this pull request Sep 26, 2018

docs: Update router guide to use Angular CLI (#20023)

1b282c2

PR Close #20023

kara pushed a commit that referenced this pull request Sep 26, 2018

docs: router guide review feedback changes (#20023)

9c36a35

PR Close #20023

kara pushed a commit that referenced this pull request Sep 26, 2018

docs: clean up providedIn: 'root' syntax for router examples (#20023)

0525276

PR Close #20023

kara pushed a commit that referenced this pull request Sep 26, 2018

docs: add section on router integration (#20023)

d52dd0a

PR Close #20023

kara pushed a commit that referenced this pull request Sep 26, 2018

docs: update routing integration section based on feedback (#20023)

159e8b4

PR Close #20023

This was referenced Oct 8, 2018

Update the lazy loading information to CLI and v6 #24109

Closed

Angular Router tutorial Milestone 3 missing information #22599

Closed

Router Guards not listed in router.config #16630

Closed

brandonroberts mentioned this pull request Nov 15, 2018

QueryParamsHandling documentation #17778

Closed

angular-automatic-lock-bot Bot unassigned jasonaden Sep 14, 2019

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 14, 2019

Conversation

brandonroberts commented Oct 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

mary-poppins commented Oct 30, 2017

Uh oh!

petebacondarwin commented Nov 29, 2017

Uh oh!

IgorMinar commented Mar 9, 2018

Uh oh!

IgorMinar commented Mar 9, 2018

Uh oh!

mary-poppins commented Mar 9, 2018

Uh oh!

brandonroberts commented Mar 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ngbot Bot commented Mar 19, 2018

Uh oh!

mary-poppins commented Apr 4, 2018

Uh oh!

ngbot Bot commented Apr 4, 2018

Uh oh!

brandonroberts commented Apr 4, 2018

Uh oh!

mary-poppins commented Apr 4, 2018

Uh oh!

mary-poppins commented Apr 4, 2018

Uh oh!

ngbot Bot commented Apr 27, 2018

Uh oh!

angular-automatic-lock-bot Bot commented Sep 14, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

brandonroberts commented Oct 30, 2017 •

edited

Loading

brandonroberts commented Mar 9, 2018 •

edited

Loading