Repository navigation
Conversation
21 of 24 tasks
Foxandxss
approved these changes
Oct 24, 2017
|
You can preview a056241 at https://pr19892-a056241.ngbuilds.io/. |
Contributor
|
missing:
|
IgorMinar
approved these changes
Nov 2, 2017
IgorMinar
left a comment
IgorMinar
left a comment
Contributor
There was a problem hiding this comment.
lgtm for navigation.json changes. the ci is still failing so this can't be merged until that is resolved.
|
You can preview 128a27b at https://pr19892-128a27b.ngbuilds.io/. |
|
You can preview 319ccfb at https://pr19892-319ccfb.ngbuilds.io/. |
|
You can preview 94eb9ce at https://pr19892-94eb9ce.ngbuilds.io/. |
Foxandxss
added
action: merge
jasonaden
pushed a commit
that referenced
this pull request
Nov 14, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #19510
PR Checklist
Please check if your PR fulfills the following requirements: