Skip to content

docs: Deployment guide for CLI - #19839

Merged
vicb merged 1 commit into
angular:masterfrom
IdeaBlade:clify-deployment
Nov 3, 2017
Merged

vicb merged 1 commit into
angular:masterfrom
IdeaBlade:clify-deployment

Conversation

@wardbell

Copy link
Copy Markdown
Contributor

See Issue # 19510

PR Checklist

Please check if your PR fulfills the following requirements:

@mary-poppins

Copy link
Copy Markdown

You can preview 0306819 at https://pr19839-0306819.ngbuilds.io/.

@mary-poppins

Copy link
Copy Markdown

You can preview 97dde14 at https://pr19839-97dde14.ngbuilds.io/.

Comment thread aio/content/guide/deployment.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xcopy -> copy

Comment thread aio/content/guide/deployment.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xcopy->copy

Comment thread aio/content/guide/deployment.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--environment=prod -> --target=prod

These two are actually different: https://github.com/angular/angular-cli/wiki/build#build-targets-and-environment-files

@wardbell wardbell Oct 23, 2017 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just compared --environment=prod vs --environment=dev and they enable/disable prodMod exactly as I said and expected.

So do --target=production vs --target=development. But the --environment flag is way more intuitive, especially after looking at main.ts

if (environment.production) {
  enableProdMode();
}

Why should I change from --environment to --target? The wiki page is not helping me understand.

Note that I mention --environment here only to talk about enableProd. I'm not talking about any of the other optimizations that would be enabled by --target=production. So I think this text is correct.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I misunderstood what was being talked about here.

Comment thread aio/content/guide/deployment.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ng build also deletes the directory, it just outputs new files there after.

Comment thread aio/content/guide/deployment.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use ng build --watch to continuously generate files.

@mary-poppins

Copy link
Copy Markdown

You can preview fd31ace at https://pr19839-fd31ace.ngbuilds.io/.

Comment thread aio/content/guide/deployment.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will deprecate the quickstart, we shouldn't name it anymore.

@mary-poppins

Copy link
Copy Markdown

You can preview d64b1fc at https://pr19839-d64b1fc.ngbuilds.io/.

@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@vicb

vicb commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

missing:

  • target label
  • merge label
  • green CI

@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Nov 2, 2017
@IgorMinar

Copy link
Copy Markdown
Contributor

@vicb the ci failure is a flake and unrelated to this change.

@IgorMinar

Copy link
Copy Markdown
Contributor

I fixed the labels. @wardbell please always apply "target" and "merge" label when your pr is ready for merge.

@Foxandxss

Copy link
Copy Markdown
Member

Yes sorry, I have too many PRs and travis is being flaky all day so I go back and forward restarting them and checking all the statuses.

@vicb
vicb merged commit 03f080b into angular:master Nov 3, 2017
vicb pushed a commit that referenced this pull request Nov 3, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants