Repository navigation
docs: Deployment guide for CLI - #19839
Conversation
|
You can preview 0306819 at https://pr19839-0306819.ngbuilds.io/. |
0306819 to
97dde14
Compare
|
You can preview 97dde14 at https://pr19839-97dde14.ngbuilds.io/. |
There was a problem hiding this comment.
--environment=prod -> --target=prod
These two are actually different: https://github.com/angular/angular-cli/wiki/build#build-targets-and-environment-files
There was a problem hiding this comment.
I just compared --environment=prod vs --environment=dev and they enable/disable prodMod exactly as I said and expected.
So do --target=production vs --target=development. But the --environment flag is way more intuitive, especially after looking at main.ts
if (environment.production) {
enableProdMode();
}
Why should I change from --environment to --target? The wiki page is not helping me understand.
Note that I mention --environment here only to talk about enableProd. I'm not talking about any of the other optimizations that would be enabled by --target=production. So I think this text is correct.
There was a problem hiding this comment.
You're right, I misunderstood what was being talked about here.
There was a problem hiding this comment.
ng build also deletes the directory, it just outputs new files there after.
There was a problem hiding this comment.
You can use ng build --watch to continuously generate files.
97dde14 to
fd31ace
Compare
|
You can preview fd31ace at https://pr19839-fd31ace.ngbuilds.io/. |
There was a problem hiding this comment.
We will deprecate the quickstart, we shouldn't name it anymore.
fd31ace to
d64b1fc
Compare
|
You can preview d64b1fc at https://pr19839-d64b1fc.ngbuilds.io/. |
|
missing:
|
|
@vicb the ci failure is a flake and unrelated to this change. |
|
I fixed the labels. @wardbell please always apply "target" and "merge" label when your pr is ready for merge. |
|
Yes sorry, I have too many PRs and travis is being flaky all day so I go back and forward restarting them and checking all the statuses. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
See Issue # 19510
PR Checklist
Please check if your PR fulfills the following requirements: