Skip to content

docs: AOT guide for CLI #19510 - #19818

Merged
vicb merged 1 commit into
angular:masterfrom
IdeaBlade:clify-aot
Nov 2, 2017
Merged

vicb merged 1 commit into
angular:masterfrom
IdeaBlade:clify-aot

Conversation

@wardbell

@wardbell wardbell commented Oct 20, 2017 •

Copy link
Copy Markdown
Contributor

See issue #19510

This PR includes copy of aot-compiler.md from PR #19818 (SHA ca214db) because this PR deletes ToH pt-6 files referenced by the current aot-compiler.md.
These two PRs must be coordinated. If there is a conflict, keep PR #19818 and discard this one.

PR Checklist

Please check if your PR fulfills the following requirements:

@wardbell wardbell self-assigned this Oct 20, 2017
@wardbell
wardbell requested a review from Foxandxss October 20, 2017 00:18
@Foxandxss Foxandxss mentioned this pull request Oct 20, 2017
21 of 24 tasks
@wardbell
wardbell force-pushed the clify-aot branch 2 times, most recently from d2bc731 to ca214db Compare October 20, 2017 17:57
@wardbell
wardbell requested a review from filipesilva October 20, 2017 22:44
Comment thread aio/content/guide/aot-compiler.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

????

Comment thread aio/content/guide/aot-compiler.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are doing ## Summary now in ToH

@Foxandxss
Foxandxss force-pushed the clify-aot branch 2 times, most recently from fba21b1 to 8f5a3d9 Compare November 2, 2017 12:55
@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@Foxandxss

Copy link
Copy Markdown
Member

The docs style guide was using some of this images so I put them again in the docs-style-guide folder.

@mary-poppins

Copy link
Copy Markdown

You can preview 6c7c65b at https://pr19818-6c7c65b.ngbuilds.io/.

@vicb

vicb commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

missing:

  • target label
  • merge label
  • green CI

@Foxandxss Foxandxss added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 2, 2017
@vicb
vicb merged commit 7186c9c into angular:master Nov 2, 2017
vicb pushed a commit that referenced this pull request Nov 2, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants