Skip to content

docs: Component Styles guide for CLI - #19791

Merged
vicb merged 1 commit into
angular:masterfrom
IdeaBlade:clify-component-styles
Nov 3, 2017
Merged

vicb merged 1 commit into
angular:masterfrom
IdeaBlade:clify-component-styles

Conversation

@wardbell

Copy link
Copy Markdown
Contributor

Issue #19510

PR Checklist

Please check if your PR fulfills the following requirements:

@wardbell wardbell self-assigned this Oct 18, 2017
@wardbell
wardbell requested a review from Foxandxss October 18, 2017 19:44
@Foxandxss Foxandxss mentioned this pull request Oct 18, 2017
21 of 24 tasks
@wardbell
wardbell force-pushed the clify-component-styles branch from 67f7edd to 0d22125 Compare October 18, 2017 19:50
@mary-poppins

Copy link
Copy Markdown

You can preview 0d22125 at https://pr19791-0d22125.ngbuilds.io/.

@wardbell
wardbell force-pushed the clify-component-styles branch from 0d22125 to cfd5eaa Compare October 20, 2017 17:54
@mary-poppins

Copy link
Copy Markdown

You can preview cfd5eaa at https://pr19791-cfd5eaa.ngbuilds.io/.

@Foxandxss
Foxandxss force-pushed the clify-component-styles branch from cfd5eaa to 77e3946 Compare November 2, 2017 12:47
@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@mary-poppins

Copy link
Copy Markdown

You can preview 77e3946 at https://pr19791-77e3946.ngbuilds.io/.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOC, isn't [1] the same as 1?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, but we are using that syntax everywhere because sometimes we have more values than 1

Comment thread aio/content/guide/component-styles.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(CSS inline --> (CSS inline)

@Foxandxss
Foxandxss force-pushed the clify-component-styles branch from 77e3946 to 1cf4181 Compare November 2, 2017 13:53
@mary-poppins

Copy link
Copy Markdown

You can preview 1cf4181 at https://pr19791-1cf4181.ngbuilds.io/.

@vicb

vicb commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

missing:

  • target label
  • merge label
  • green CI

@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Nov 2, 2017
@ocombe ocombe added the action: merge The PR is ready for merge by the caretaker label Nov 3, 2017
@vicb
vicb merged commit 567cc26 into angular:master Nov 3, 2017
vicb pushed a commit that referenced this pull request Nov 3, 2017
@wardbell
wardbell deleted the clify-component-styles branch November 30, 2017 00:51
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants