Skip to content

docs: Bootstrapping guide prose for CLI - #19777

Merged
vicb merged 1 commit into
angular:masterfrom
IdeaBlade:clify-bootstrapping
Nov 3, 2017
Merged

docs: Bootstrapping guide prose for CLI#19777
vicb merged 1 commit into
angular:masterfrom
IdeaBlade:clify-bootstrapping

Conversation

@wardbell

@wardbell wardbell commented Oct 18, 2017

Copy link
Copy Markdown
Contributor

See issue #19510.

PR Checklist

Please check if your PR fulfills the following requirements:

@wardbell wardbell self-assigned this Oct 18, 2017
@wardbell
wardbell requested a review from Foxandxss October 18, 2017 07:52
@mary-poppins

mary-poppins commented Oct 18, 2017

Copy link
Copy Markdown

You can preview 789dbd6 at https://pr19777-789dbd6.ngbuilds.io/.

@Foxandxss Foxandxss mentioned this pull request Oct 18, 2017
Closed
21 of 24 tasks
Foxandxss
Foxandxss approved these changes Oct 24, 2017
View reviewed changes
Comment thread aio/content/guide/bootstrapping.md Outdated

@Foxandxss Foxandxss Oct 24, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldnt be better to point to the getting started?

@Foxandxss
Foxandxss force-pushed the clify-bootstrapping branch from 789dbd6 to 1ff3ec5 Compare November 2, 2017 12:40
@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@mary-poppins

mary-poppins commented Nov 2, 2017

Copy link
Copy Markdown

You can preview 1ff3ec5 at https://pr19777-1ff3ec5.ngbuilds.io/.

gkalpak
gkalpak reviewed Nov 2, 2017
View reviewed changes
Comment thread aio/content/guide/bootstrapping.md Outdated

@gkalpak gkalpak Nov 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular Module --> Angular Modules

Comment thread aio/content/guide/bootstrapping.md Outdated

@gkalpak gkalpak Nov 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

produce --> produces

@Foxandxss Foxandxss Nov 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love when you correct Ward 😂

Comment thread aio/content/guide/bootstrapping.md Outdated

@gkalpak gkalpak Nov 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HttpModule --> HttpClientModule(?)

@Foxandxss
Foxandxss force-pushed the clify-bootstrapping branch from 1ff3ec5 to ab4b22e Compare November 2, 2017 13:55
@mary-poppins

mary-poppins commented Nov 2, 2017

Copy link
Copy Markdown

You can preview ab4b22e at https://pr19777-ab4b22e.ngbuilds.io/.

@vicb

vicb commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

missing:

  • target label
  • merge label
  • green CI

@Foxandxss Foxandxss added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 2, 2017
@vicb
vicb merged commit 169cedd into angular:master Nov 3, 2017
vicb pushed a commit that referenced this pull request Nov 3, 2017
@wardbell @vicb
docs: Bootstrapping guide prose for CLI (#19777)
9811bef
@wardbell
wardbell deleted the clify-bootstrapping branch December 13, 2017 00:36
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 13, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@gkalpak gkalpak gkalpak left review comments
@Foxandxss Foxandxss Foxandxss approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@wardbell wardbell

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

5.0.x

Development

Successfully merging this pull request may close these issues.

6 participants

@wardbell @mary-poppins @vicb @Foxandxss @gkalpak @googlebot