Skip to content

docs: AttributeDirectives guide for CLI - #19771

Closed
wardbell wants to merge 1 commit into
angular:masterfrom
IdeaBlade:clify-attr-directives
Closed

docs: AttributeDirectives guide for CLI#19771
wardbell wants to merge 1 commit into
angular:masterfrom
IdeaBlade:clify-attr-directives

Conversation

@wardbell

@wardbell wardbell commented Oct 17, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

See #19510 "CLI prose changes"

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

@wardbell wardbell self-assigned this Oct 17, 2017
@wardbell
wardbell requested a review from Foxandxss October 17, 2017 23:48
@Foxandxss Foxandxss mentioned this pull request Oct 17, 2017
Closed
21 of 24 tasks
@mary-poppins

mary-poppins commented Oct 18, 2017

Copy link
Copy Markdown

You can preview 6bd2ba9 at https://pr19771-6bd2ba9.ngbuilds.io/.

@Foxandxss Foxandxss added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 2, 2017
@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@Foxandxss
Foxandxss force-pushed the clify-attr-directives branch from 6bd2ba9 to acab3c2 Compare November 2, 2017 12:38
@mary-poppins

mary-poppins commented Nov 2, 2017

Copy link
Copy Markdown

You can preview acab3c2 at https://pr19771-acab3c2.ngbuilds.io/.

gkalpak
gkalpak reviewed Nov 2, 2017
View reviewed changes
Comment thread aio/content/guide/attribute-directives.md Outdated

@gkalpak gkalpak Nov 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the : intentional?

@Foxandxss Foxandxss Nov 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so

@vicb

vicb commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

missing:

  • green CI

@Foxandxss
Foxandxss force-pushed the clify-attr-directives branch from acab3c2 to ecdf7da Compare November 3, 2017 20:57
@mary-poppins

mary-poppins commented Nov 3, 2017

Copy link
Copy Markdown

You can preview ecdf7da at https://pr19771-ecdf7da.ngbuilds.io/.

@gkalpak

gkalpak commented Nov 3, 2017

Copy link
Copy Markdown
Member

CircleCI didn't find the config and runs its default commands. I tried restarting it a couple of times to no avail 😕

@jasonaden

jasonaden commented Nov 10, 2017

Copy link
Copy Markdown
Contributor

@wardbell There's one outstanding comment. Also, please rebase and re-push which should fix the CI error. If it doesn't, I'll rebase locally and merge.

@Foxandxss

Foxandxss commented Nov 10, 2017

Copy link
Copy Markdown
Member

Sorry @jasonaden , long angular connect week. I will see what can I do.

@Foxandxss
Foxandxss force-pushed the clify-attr-directives branch from ecdf7da to a29fca1 Compare November 13, 2017 09:47
@mary-poppins

mary-poppins commented Nov 13, 2017

Copy link
Copy Markdown

You can preview a29fca1 at https://pr19771-a29fca1.ngbuilds.io/.

@jasonaden jasonaden closed this in 75d474e Nov 14, 2017
jasonaden pushed a commit that referenced this pull request Nov 14, 2017
@wardbell @jasonaden
docs: AttributeDirectives guide for CLI (#19771)
eea2039 
PR Close #19771
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@Foxandxss Foxandxss Foxandxss approved these changes
@gkalpak gkalpak gkalpak left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@wardbell wardbell

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

5.0.x

Development

Successfully merging this pull request may close these issues.

7 participants

@wardbell @mary-poppins @vicb @gkalpak @jasonaden @Foxandxss @googlebot