Repository navigation
Conversation
tbosch
changed the title
TestBed.overrideProvider should keep imported NgModules eager
chuckjaz
approved these changes
Oct 9, 2017
|
You can preview cfcf3f9 at https://pr19624-cfcf3f9.ngbuilds.io/. |
|
You can preview 43a461a at https://pr19624-43a461a.ngbuilds.io/. |
tbosch
added
area: core
chuckjaz
approved these changes
Oct 10, 2017
…ule`s eager Before, as soon as a user called `TestBed.overrideProvider` for a provider of a `NgModule` that was imported via `TestBed.configureTestingModule`, that `NgModule` became lazy. This commit changes this behavior to keep the `NgModule` eager, with or without a call to `TestBed.overrideProvider`.
tbosch
force-pushed
the
fix_providers2
branch
from
October 10, 2017 20:46
43a461a to
4a8b9a7
Compare
|
You can preview 4a8b9a7 at https://pr19624-4a8b9a7.ngbuilds.io/. |
chuckjaz
pushed a commit
that referenced
this pull request
Oct 11, 2017
…ule`s eager (#19624) Before, as soon as a user called `TestBed.overrideProvider` for a provider of a `NgModule` that was imported via `TestBed.configureTestingModule`, that `NgModule` became lazy. This commit changes this behavior to keep the `NgModule` eager, with or without a call to `TestBed.overrideProvider`. PR Close #19624
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first 2 commits are from #19558. Before this PR is merged, we need to change some tests in G3 to use the new
TestBed.deprecatedOverrideProviderso they won't break.