fix(compiler): correctly instantiate eager providers that are used vi… by tbosch · Pull Request #19558 · angular/angular

tbosch · 2017-10-04T17:31:28Z

…a Injector.get

This also fixes the problem that all NgModule instances
became lazy when using TestBed.overrideProvider.

Closes #15501

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

mary-poppins · 2017-10-04T17:39:55Z

You can preview 1fa3687 at https://pr19558-1fa3687.ngbuilds.io/.

mary-poppins · 2017-10-04T21:39:48Z

You can preview 6328cff at https://pr19558-6328cff.ngbuilds.io/.

mary-poppins · 2017-10-04T21:52:00Z

You can preview 1c52a1d at https://pr19558-1c52a1d.ngbuilds.io/.

mary-poppins · 2017-10-04T22:30:54Z

You can preview 3575640 at https://pr19558-3575640.ngbuilds.io/.

mary-poppins · 2017-10-09T15:27:38Z

You can preview d7ca43c at https://pr19558-d7ca43c.ngbuilds.io/.

mary-poppins · 2017-10-09T16:15:06Z

You can preview 3434b82 at https://pr19558-3434b82.ngbuilds.io/.

mary-poppins · 2017-10-09T16:42:47Z

You can preview 76483ed at https://pr19558-76483ed.ngbuilds.io/.

mary-poppins · 2017-10-09T20:55:36Z

You can preview 6ce1a62 at https://pr19558-6ce1a62.ngbuilds.io/.

…a `Injector.get` Closes angular#15501

This allows use to fix `TestBed.overrideProvider` to keep imported `NgModule`s eager, while allowing our users to still keep the old semantics until they have fixed their tests.

tbosch · 2017-10-09T21:23:09Z

@IgorMinar approves this change (talked offline).

…19558) This allows use to fix `TestBed.overrideProvider` to keep imported `NgModule`s eager, while allowing our users to still keep the old semantics until they have fixed their tests. PR Close #19558

…a `Injector.get` (#19558) Closes #15501 PR Close #19558

…19558) This allows use to fix `TestBed.overrideProvider` to keep imported `NgModule`s eager, while allowing our users to still keep the old semantics until they have fixed their tests. PR Close #19558

BREAKING CHANGE In PR angular#19558, we fixed a bug in `TestBed.overrideProvider` where eager providers were not being instantiated correctly. However, it turned out that since this bug had been around for quite a bit, many apps were relying on the broken behavior where the providers would not be instantiated. To assist in the transition, the `TestBed.deprecatedOverrideProvider` method was temporarily introduced to mimic the old behavior so that apps would have a longer time period to migrate their code. 2 years and 3 versions later, it is time to remove the temporary method. This commit removes `TestBed.deprecatedOverrideProvider` altogether. Any usages of `TestBed.deprecatedOverrideProvider` should be replaced with `TestBed.overrideProvider`. This may mean that providers that were not created before will now be instantiated, which could mean that your tests need to provide more mocks or stubs for the dependencies of the newly instantiated providers.

…#30576) BREAKING CHANGE In PR #19558, we fixed a bug in `TestBed.overrideProvider` where eager providers were not being instantiated correctly. However, it turned out that since this bug had been around for quite a bit, many apps were relying on the broken behavior where the providers would not be instantiated. To assist in the transition, the `TestBed.deprecatedOverrideProvider` method was temporarily introduced to mimic the old behavior so that apps would have a longer time period to migrate their code. 2 years and 3 versions later, it is time to remove the temporary method. This commit removes `TestBed.deprecatedOverrideProvider` altogether. Any usages of `TestBed.deprecatedOverrideProvider` should be replaced with `TestBed.overrideProvider`. This may mean that providers that were not created before will now be instantiated, which could mean that your tests need to provide more mocks or stubs for the dependencies of the newly instantiated providers. PR Close #30576

angular-automatic-lock-bot · 2019-09-12T18:50:43Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

tbosch requested a review from chuckjaz October 4, 2017 17:31

googlebot added the cla: yes label Oct 4, 2017

tbosch added area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release hotlist: google and removed cla: yes labels Oct 4, 2017

chuckjaz approved these changes Oct 4, 2017

View reviewed changes

googlebot added the cla: yes label Oct 4, 2017

tbosch force-pushed the fix_providers branch from 6328cff to 1c52a1d Compare October 4, 2017 21:43

tbosch added the action: merge The PR is ready for merge by the caretaker label Oct 4, 2017

tbosch force-pushed the fix_providers branch from 1c52a1d to 3575640 Compare October 4, 2017 22:10

tbosch removed the action: merge The PR is ready for merge by the caretaker label Oct 4, 2017

tbosch force-pushed the fix_providers branch 2 times, most recently from 6831beb to d7ca43c Compare October 9, 2017 15:17

tbosch force-pushed the fix_providers branch from d7ca43c to 3434b82 Compare October 9, 2017 16:06

tbosch force-pushed the fix_providers branch from 3434b82 to 76483ed Compare October 9, 2017 16:31

tbosch force-pushed the fix_providers branch from 76483ed to 6ce1a62 Compare October 9, 2017 20:44

tbosch added 2 commits October 9, 2017 14:06

fix(compiler): correctly instantiate eager providers that are used vi…

27812d6

…a `Injector.get` Closes angular#15501

refactor(compiler): introduce TestBed.deprecatedOverrideProvider

cfcf3f9

This allows use to fix `TestBed.overrideProvider` to keep imported `NgModule`s eager, while allowing our users to still keep the old semantics until they have fixed their tests.

tbosch force-pushed the fix_providers branch from 6ce1a62 to cfcf3f9 Compare October 9, 2017 21:10

tbosch mentioned this pull request Oct 9, 2017

fix(compiler): TestBed.overrideProvider should keep imported NgModules eager #19624

Closed

tbosch added the action: merge The PR is ready for merge by the caretaker label Oct 9, 2017

chuckjaz added this to the Merge-queue milestone Oct 9, 2017

chuckjaz closed this in 6ade68c Oct 10, 2017

chuckjaz pushed a commit that referenced this pull request Oct 11, 2017

fix(compiler): correctly instantiate eager providers that are used vi…

e292548

…a `Injector.get` (#19558) Closes #15501 PR Close #19558

tbosch deleted the fix_providers branch October 17, 2017 23:03

trotyl mentioned this pull request Feb 13, 2018

Providing from inheritor to constructor of base component doesn't work in Angular 4 #15615

Closed

trotyl mentioned this pull request Feb 20, 2018

APP_INITIALIZER not injecting using Injector class #14459

Closed

kara mentioned this pull request May 21, 2019

fix(core): remove TestBed.deprecatedOverrideProvider #30576

Closed

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019

Navigation Menu

Repository navigation

fix(compiler): correctly instantiate eager providers that are used vi… - #19558

fix(compiler): correctly instantiate eager providers that are used vi…#19558
tbosch wants to merge 2 commits into
angular:masterfrom
tbosch:fix_providers

tbosch commented Oct 4, 2017

Uh oh!

mary-poppins commented Oct 4, 2017

Uh oh!

mary-poppins commented Oct 4, 2017

Uh oh!

mary-poppins commented Oct 4, 2017

Uh oh!

mary-poppins commented Oct 4, 2017

Uh oh!

mary-poppins commented Oct 9, 2017

Uh oh!

mary-poppins commented Oct 9, 2017

Uh oh!

mary-poppins commented Oct 9, 2017

Uh oh!

mary-poppins commented Oct 9, 2017

Uh oh!

tbosch commented Oct 9, 2017

Uh oh!

angular-automatic-lock-bot Bot commented Sep 12, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

tbosch commented Oct 4, 2017

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

mary-poppins commented Oct 4, 2017

Uh oh!

mary-poppins commented Oct 4, 2017

Uh oh!

mary-poppins commented Oct 4, 2017

Uh oh!

mary-poppins commented Oct 4, 2017

Uh oh!

mary-poppins commented Oct 9, 2017

Uh oh!

mary-poppins commented Oct 9, 2017

Uh oh!

mary-poppins commented Oct 9, 2017

Uh oh!

mary-poppins commented Oct 9, 2017

Uh oh!

tbosch commented Oct 9, 2017

Uh oh!

angular-automatic-lock-bot Bot commented Sep 12, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants