Skip to content

docs(aio): update pipes for CLI - #19553

Merged
vicb merged 1 commit into
angular:masterfrom
IdeaBlade:aio-cli-pipes
Nov 3, 2017
Merged

vicb merged 1 commit into
angular:masterfrom
IdeaBlade:aio-cli-pipes

Conversation

@Foxandxss

Copy link
Copy Markdown
Member

Part of #19510

I was deciding between deleting the callout altogether or updating it.

@IgorMinar IgorMinar added the target: major This PR is targeted for the next major release label Oct 10, 2017

@wardbell wardbell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and urgent to get aligned with v.5
We can do more polishing later

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Nov 2, 2017
@IgorMinar IgorMinar added this to the 5.0.x milestone Nov 2, 2017
@vicb

vicb commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

I'm not merging red PRs without comment

@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Nov 3, 2017
@IgorMinar

Copy link
Copy Markdown
Contributor

I've changed the label to master&patch. we want this change to be cherry-picked into the 5.0.x branch

@IgorMinar

Copy link
Copy Markdown
Contributor

I've restarted the failed job. looks like a flake of some sort. I haven't seen this failure before.

@mary-poppins

Copy link
Copy Markdown

You can preview 56e3f11 at https://pr19553-56e3f11.ngbuilds.io/.

@vicb
vicb merged commit dbec3ca into angular:master Nov 3, 2017
vicb pushed a commit that referenced this pull request Nov 3, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants