Skip to content

test(aio): fix tests for example-boilerplate - #18619

Merged
vicb merged 1 commit into
angular:4.3.xfrom
gkalpak:test-aio-fix-43x
Aug 10, 2017
Merged

vicb merged 1 commit into
angular:4.3.xfrom
gkalpak:test-aio-fix-43x

Conversation

@gkalpak

@gkalpak gkalpak commented Aug 9, 2017

Copy link
Copy Markdown
Member

PR #18520 was accidentally merged into 4.3.x, which uses a different location for building tsc-wrapped. This commit reverts the changes from #18520 that were not compatible with 4.3.x.

PR angular#18520 was accidentally merged into 4.3.x, which uses a different
location for building `tsc-wrapped`. This commit reverts the changes
from angular#18520 that were not compatible with 4.3.x.
@gkalpak gkalpak added comp: aio area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer state: WIP and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 9, 2017
@mary-poppins

Copy link
Copy Markdown

You can preview 86b55ee at https://pr18619-86b55ee.ngbuilds.io/.

@gkalpak gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Aug 10, 2017
@vicb

vicb commented Aug 10, 2017

Copy link
Copy Markdown
Contributor

LGTM @IgorMinar please add the official stamp

@vicb vicb added PR target: patch-only and removed action: review The PR is still awaiting reviews from at least one requested reviewer PR target: patch-only labels Aug 10, 2017
@vicb
vicb merged commit 77fa3c3 into angular:4.3.x Aug 10, 2017
@gkalpak
gkalpak deleted the test-aio-fix-43x branch August 10, 2017 06:50
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: build & ci Related the build and CI infrastructure of the project cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants