Skip to content

Cleanup ngc api - #18614

Closed
tbosch wants to merge 2 commits into
angular:masterfrom
tbosch:ngc_api
Closed

tbosch wants to merge 2 commits into
angular:masterfrom
tbosch:ngc_api

Conversation

@tbosch

@tbosch tbosch commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

The first commit is from #18494.

vicb and others added 2 commits August 9, 2017 11:59
The source map does not currently work with the transformer pipeline.
It will be re-enabled after TypeScript 2.4 is made the min version.

To revert to the former compiler, use the `disableTransformerPipeline` in
tsconfig.json:

```
{
  "angularCompilerOptions": {
    "disableTransformerPipeline": true
  }
}
```
@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@mary-poppins

Copy link
Copy Markdown

You can preview 3dc55e2 at https://pr18614-3dc55e2.ngbuilds.io/.

@tbosch
tbosch requested review from chuckjaz and vicb August 10, 2017 01:05
@tbosch

tbosch commented Aug 10, 2017

Copy link
Copy Markdown
Contributor Author

Closing, somehow Github is not pciking up my changes...

@tbosch tbosch closed this Aug 10, 2017
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants