Skip to content

docs(core): deprecate ReflectiveInjector in docs #18598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trotyl wants to merge 1 commit into from
Closed

docs(core): deprecate ReflectiveInjector in docs #18598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/di/reflective_injector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const UNDEFINED = new Object();
* Notice, we don't use the `new` operator because we explicitly want to have the `Injector`
* resolve all of the object's dependencies automatically.
*
* @stable
* @deprecated

@IgorMinar IgorMinar Aug 9, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add "Use the light-weight alternative Injector.create instead of ReflectiveInjector which is slow and brings in a lot of code."

*/
export abstract class ReflectiveInjector implements Injector {
/**
Expand Down
2 changes: 1 addition & 1 deletion tools/public_api_guard/core/core.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ export declare class QueryList<T> {
toString(): string;
}

/** @stable */
/** @deprecated */
export declare abstract class ReflectiveInjector implements Injector {
readonly abstract parent: Injector | null;
abstract createChildFromResolved(providers: ResolvedReflectiveProvider[]): ReflectiveInjector;
Expand Down