Skip to content

docs(core): deprecate ReflectiveInjector in docs - #18598

Closed
trotyl wants to merge 1 commit into
angular:masterfrom
trotyl:deprecate-reflective-injector
Closed

docs(core): deprecate ReflectiveInjector in docs#18598
trotyl wants to merge 1 commit into
angular:masterfrom
trotyl:deprecate-reflective-injector

Conversation

@trotyl

@trotyl trotyl commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

In fcadbf4 , it is saying:

DEPRECATION:

  • ReflectiveInjector is now deprecated as it will be remove. Use
    Injector.create as a replacement.

But the API documentation was not updated.

What is the new behavior?

Update the API documentation about the deprecated status of ReflectiveInjector.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vicb vicb added comp: docs area: core Issues related to the framework runtime action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Aug 9, 2017
IgorMinar
IgorMinar approved these changes Aug 9, 2017
View reviewed changes
Comment thread packages/core/src/di/reflective_injector.ts
* resolve all of the object's dependencies automatically.
*
* @stable
* @deprecated

@IgorMinar IgorMinar Aug 9, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add "Use the light-weight alternative Injector.create instead of ReflectiveInjector which is slow and brings in a lot of code."

@vicb vicb closed this in dca50de Aug 9, 2017
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@trotyl Zhicheng Wang
docs(core): deprecate ReflectiveInjector
1276d92 
closes angular#18598
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
@trotyl @juleskremer
docs(core): deprecate ReflectiveInjector
93548dc 
closes angular#18598
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@trotyl @juleskremer
docs(core): deprecate ReflectiveInjector
18326ff 
closes angular#18598
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@IgorMinar IgorMinar IgorMinar approved these changes
@vicb vicb vicb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trotyl @IgorMinar @vicb @googlebot