Skip to content

docs(common): fix the worng sample - #18548

Merged
vicb merged 1 commit into
angular:masterfrom
poychang:my-fix-branch
Aug 7, 2017
Merged

docs(common): fix the worng sample#18548
vicb merged 1 commit into
angular:masterfrom
poychang:my-fix-branch

Conversation

@poychang

@poychang poychang commented Aug 5, 2017

Copy link
Copy Markdown
Contributor

Those two sample code should be opposite.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Those two sample code of DatePipe should be opposite.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@poychang
docs(common): fix the worng sample
acc8ea8 
Those two sample code should be opposite.
gkalpak
gkalpak approved these changes Aug 5, 2017
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the commit message.

@vicb vicb added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Aug 7, 2017
@vicb
vicb merged commit 04b18a9 into angular:master Aug 7, 2017
@poychang
poychang deleted the my-fix-branch branch August 8, 2017 02:08
vicb pushed a commit that referenced this pull request Aug 8, 2017
@poychang @vicb
docs(common): fix the DatePipe API docs (#18548)
c8fd3f5
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@poychang Zhicheng Wang
docs(common): fix the DatePipe API docs (angular#18548)
f43f9f0
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
@poychang @juleskremer
docs(common): fix the DatePipe API docs (angular#18548)
9ed19d6
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@poychang @juleskremer
docs(common): fix the DatePipe API docs (angular#18548)
99d9bb4
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@vicb vicb vicb approved these changes
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@poychang @vicb @gkalpak @googlebot