Repository navigation
fix(compiler-cli): remove minimist dependency when importing compiler-cli - #18532
Merged
Merged
Conversation
|
You can preview 6717370 at https://pr18532-6717370.ngbuilds.io/. |
vicb
reviewed
Aug 7, 2017
Contributor
There was a problem hiding this comment.
Could we:
- come with a more descriptive name,
- add a quick comment ?
IMO even more important now that the fn is exported.
Contributor
|
LGTM, could you fix the name ? |
chuckjaz
force-pushed
the
lg-minmist-fix
branch
2 times, most recently
from
August 7, 2017 18:09
5bf56f8 to
4738be2
Compare
|
You can preview 5bf56f8 at https://pr18532-5bf56f8.ngbuilds.io/. |
Indirectly removes the minimist dependency in the language service package was added with the addition of `ngc.ts`.
chuckjaz
force-pushed
the
lg-minmist-fix
branch
from
August 7, 2017 18:13
4738be2 to
8e4b299
Compare
vicb
approved these changes
Aug 7, 2017
vicb
added
action: merge
|
You can preview 4738be2 at https://pr18532-4738be2.ngbuilds.io/. |
|
You can preview 8e4b299 at https://pr18532-8e4b299.ngbuilds.io/. |
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…ngular#18532) Indirectly removes the minimist dependency in the language service package was added with the addition of `ngc.ts`.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 26, 2017
…ngular#18532) Indirectly removes the minimist dependency in the language service package was added with the addition of `ngc.ts`.
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…ngular#18532) Indirectly removes the minimist dependency in the language service package was added with the addition of `ngc.ts`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indirectly removes the minimist dependency in the language service that
was added with the addition of
ngc.ts.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Loading the
@angular/language-servicerequires theminimistpackage installed.What is the new behavior?
Loading the
@angular/language-serviceno longer requiresminimist.Does this PR introduce a breaking change?