test(aio): fix running docs examples against local builds by gkalpak · Pull Request #18520 · angular/angular

gkalpak · 2017-08-04T00:48:47Z

This commit also updates the version of @angular/cli used for docs examples.

The previous (transient) dependency @ngtools/webpack was not compatible with @angular/compiler-cli@>=5 and was breaking when running against the local builds (currently at 5.0.0-beta.2).

The version of @ngtools/webpack used by the latest @angular/cli version is compatible with @angular/compiler-cli@5.

gkalpak · 2017-08-04T00:53:51Z

BTW, once this is fixed, one can run the docs examples with the local builds with:

# Build the @angular packages
cd angular
npm install && ./builds.sh

# Install the examples' boilerplate (including dependencies)
cd aio
yarn && yarn boilerplate:add -- --local

# Build and serve an example locally
cd content/examples/<example-name>
npm start

mary-poppins · 2017-08-04T00:59:38Z

You can preview 22c699b at https://pr18520-22c699b.ngbuilds.io/.

mary-poppins · 2017-08-04T01:12:10Z

You can preview 77458ed at https://pr18520-77458ed.ngbuilds.io/.

petebacondarwin · 2017-08-04T04:44:14Z

Did someone move the tsc-wrapped folder?

Ahah!
619e625

petebacondarwin · 2017-08-04T04:45:52Z

Why this change?
Does it not work on Windows?
The idea of symlinking meant that you didn't need to keep running add-boilerplate all the time, while working on the source.

I can't try on Windows, but it didn't work on Ubuntu either. I was getting errors from files in dist/packages-dist/... that it couldn't find @angular/core for example. Seems like the double symlinking (packages-dist --> shared/node_modules --> /node_modules) threw it off.

Maybe we could get by, by copying the symlinks (instead of re-symlinking) from shared/node_modules/@angular if in local mode.

Oh, that wouldn't actually work, because we symlink to the shared/node_modules/ directory as a whole 😞

So, I confirmed the symlinking fails on Travis too, so it was not a local issue in my Ubuntu VM.
Sticking with copying (and having to re-add the boilerplate if you re-build Angular packages).

petebacondarwin · 2017-08-04T04:46:13Z

mary-poppins · 2017-08-04T09:09:54Z

You can preview da6f003 at https://pr18520-da6f003.ngbuilds.io/.

mary-poppins · 2017-08-04T09:54:02Z

You can preview 74e5e6f at https://pr18520-74e5e6f.ngbuilds.io/.

This commit also updates the version of `@angular/cli` used for docs examples. The previous (transient) dependency `@ngtools/webpack` was not compatible with `@angular/compiler-cli@>=5` and was breaking when running against the local builds (currently at 5.0.0-beta.2). The version of `@ngtools/webpack` used by the latest `@angular/cli` version is compatible with `@angular/compiler-cli@5`.

gkalpak · 2017-08-04T10:41:21Z

Updated the example-boilerplate.js tests and ensured they are run on CI.

mary-poppins · 2017-08-04T10:46:46Z

You can preview 48c9cd3 at https://pr18520-48c9cd3.ngbuilds.io/.

mary-poppins · 2017-08-04T10:54:42Z

You can preview 74bc809 at https://pr18520-74bc809.ngbuilds.io/.

This commit also updates the version of `@angular/cli` used for docs examples. The previous (transient) dependency `@ngtools/webpack` was not compatible with `@angular/compiler-cli@>=5` and was breaking when running against the local builds (currently at 5.0.0-beta.2). The version of `@ngtools/webpack` used by the latest `@angular/cli` version is compatible with `@angular/compiler-cli@5`.

PR angular#18520 was accidentally merged into 4.3.x, which uses a different location for building `tsc-wrapped`. This commit reverts the changes from angular#18520 that were not compatible with 4.3.x.

PR #18520 was accidentally merged into 4.3.x, which uses a different location for building `tsc-wrapped`. This commit reverts the changes from #18520 that were not compatible with 4.3.x.

) This commit also updates the version of `@angular/cli` used for docs examples. The previous (transient) dependency `@ngtools/webpack` was not compatible with `@angular/compiler-cli@>=5` and was breaking when running against the local builds (currently at 5.0.0-beta.2). The version of `@ngtools/webpack` used by the latest `@angular/cli` version is compatible with `@angular/compiler-cli@5`.

angular-automatic-lock-bot · 2019-09-12T06:21:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Aug 4, 2017

gkalpak added comp: aio area: build & ci Related the build and CI infrastructure of the project state: WIP type: bug/fix labels Aug 4, 2017

gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Aug 4, 2017

petebacondarwin reviewed Aug 4, 2017

View reviewed changes

gkalpak force-pushed the test-aio-fix-e2e-local branch from 77458ed to da6f003 Compare August 4, 2017 08:59

gkalpak force-pushed the test-aio-fix-e2e-local branch from da6f003 to 74e5e6f Compare August 4, 2017 09:45

gkalpak force-pushed the test-aio-fix-e2e-local branch from 74e5e6f to 48c9cd3 Compare August 4, 2017 10:39

gkalpak changed the title ~~test(aio): fix running against local builds~~ test(aio): fix running docs examples against local builds Aug 4, 2017

gkalpak force-pushed the test-aio-fix-e2e-local branch from 48c9cd3 to 74bc809 Compare August 4, 2017 10:42

gkalpak added target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 9, 2017

IgorMinar approved these changes Aug 9, 2017

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 9, 2017

vicb merged commit 7f2037f into angular:master Aug 9, 2017

gkalpak mentioned this pull request Aug 9, 2017

test(aio): fix tests for example-boilerplate #18619

Merged

gkalpak deleted the test-aio-fix-e2e-local branch August 10, 2017 01:04

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019

Conversation

gkalpak commented Aug 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gkalpak commented Aug 4, 2017

Uh oh!

mary-poppins commented Aug 4, 2017

Uh oh!

mary-poppins commented Aug 4, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Aug 4, 2017

Uh oh!

mary-poppins commented Aug 4, 2017

Uh oh!

gkalpak commented Aug 4, 2017

Uh oh!

mary-poppins commented Aug 4, 2017

Uh oh!

mary-poppins commented Aug 4, 2017

Uh oh!

angular-automatic-lock-bot Bot commented Sep 12, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gkalpak commented Aug 4, 2017 •

edited

Loading