Skip to content

fix(aio): fix layout of the webpack guide - #18493

Merged
vicb merged 1 commit into
angular:masterfrom
gkalpak:fix-aio-webpack-guide
Aug 2, 2017
Merged

vicb merged 1 commit into
angular:masterfrom
gkalpak:fix-aio-webpack-guide

Conversation

@gkalpak

@gkalpak gkalpak commented Aug 2, 2017

Copy link
Copy Markdown
Member

This is possibly a temporary fix for the layout, until we decide whether we want to remove the guide or properly add it to the SideNav menu.

Fixes #17912.

This is possibly a temporary fix for the layout, until we decide whether we want
to remove the guide or properly add it to the SideNav menu.

Fixes angular#17912
@gkalpak gkalpak added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer and removed comp: docs labels Aug 2, 2017
@mary-poppins

Copy link
Copy Markdown

You can preview ec04a19 at https://pr18493-ec04a19.ngbuilds.io/.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 2, 2017
@vicb
vicb merged commit 44ae6e9 into angular:master Aug 2, 2017
vicb pushed a commit that referenced this pull request Aug 2, 2017
This is possibly a temporary fix for the layout, until we decide whether we want
to remove the guide or properly add it to the SideNav menu.

Fixes #17912
@gkalpak
gkalpak deleted the fix-aio-webpack-guide branch August 3, 2017 08:59
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
This is possibly a temporary fix for the layout, until we decide whether we want
to remove the guide or properly add it to the SideNav menu.

Fixes angular#17912
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
This is possibly a temporary fix for the layout, until we decide whether we want
to remove the guide or properly add it to the SideNav menu.

Fixes angular#17912
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
This is possibly a temporary fix for the layout, until we decide whether we want
to remove the guide or properly add it to the SideNav menu.

Fixes angular#17912
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aio: webpack guide style issue

5 participants