Skip to content

fix(compiler-cli): modified ngc to throw all errors, not just syntax - #18388

Merged
vicb merged 1 commit into
angular:masterfrom
adeora:ngc-throw
Aug 3, 2017
Merged

fix(compiler-cli): modified ngc to throw all errors, not just syntax#18388
vicb merged 1 commit into
angular:masterfrom
adeora:ngc-throw

Conversation

@adeora

@adeora adeora commented Jul 27, 2017

Copy link
Copy Markdown
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

ngc's performCompilation method now throws all errors, not just syntax errors

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

ngc's performCompilation method only throws syntax errors, with others silently being caught

Issue Number: N/A

What is the new behavior?

ngc's performCompilation method now throws all errors, not just syntax errors

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@vicb vicb mentioned this pull request Aug 3, 2017
Merged
1 task done
@vicb vicb added area: core Issues related to the framework runtime flag: can be closed? labels Aug 3, 2017
@chuckjaz chuckjaz added the action: merge The PR is ready for merge by the caretaker label Aug 3, 2017
@vicb vicb added the target: major This PR is targeted for the next major release label Aug 3, 2017
@vicb
vicb merged commit 5651e4a into angular:master Aug 3, 2017
@vicb vicb mentioned this pull request Aug 3, 2017
Merged
@chuckjaz chuckjaz mentioned this pull request Aug 7, 2017
Merged
chuckjaz added a commit to chuckjaz/angular that referenced this pull request Aug 8, 2017
@chuckjaz
fix(compiler-cli): fix and re-enble expression lowering
3bd00f9 
Fixes issue uncovered by angular#18388 and re-enables expression
lowering disabled by angular#18513.
vicb pushed a commit that referenced this pull request Aug 8, 2017
@chuckjaz @vicb
fix(compiler-cli): fix and re-enble expression lowering (#18570)
6f2038c 
Fixes issue uncovered by #18388 and re-enables expression
lowering disabled by #18513.
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@adeora Zhicheng Wang
fix(compiler-cli): modified ngc to throw all errors, not just syntax (a…
f5e31a6 
…ngular#18388)
asnowwolf pushed a commit to asnowwolf/angular that referenced this pull request Aug 11, 2017
@chuckjaz Zhicheng Wang
fix(compiler-cli): fix and re-enble expression lowering (angular#18570)
2d357f1 
Fixes issue uncovered by angular#18388 and re-enables expression
lowering disabled by angular#18513.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
@adeora @juleskremer
fix(compiler-cli): modified ngc to throw all errors, not just syntax (a…
dd632bf 
…ngular#18388)
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 26, 2017
@chuckjaz @juleskremer
fix(compiler-cli): fix and re-enble expression lowering (angular#18570)
716fe2b 
Fixes issue uncovered by angular#18388 and re-enables expression
lowering disabled by angular#18513.
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@adeora @juleskremer
fix(compiler-cli): modified ngc to throw all errors, not just syntax (a…
1e4f702 
…ngular#18388)
juleskremer pushed a commit to juleskremer/angular that referenced this pull request Aug 28, 2017
@chuckjaz @juleskremer
fix(compiler-cli): fix and re-enble expression lowering (angular#18570)
5825979 
Fixes issue uncovered by angular#18388 and re-enables expression
lowering disabled by angular#18513.
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@chuckjaz chuckjaz chuckjaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adeora @chuckjaz @vicb @googlebot