Repository navigation
[5.X branch only] fix(common): don't recreate view when context shape doesn't change - #18277
Merged
vicb merged 1 commit intoAug 7, 2017
Conversation
pkozlowski-opensource
added
area: common
vicb
reviewed
Jul 21, 2017
vicb
reviewed
Jul 21, 2017
Contributor
There was a problem hiding this comment.
ctxChange: SimpleChange is not correct (might be undefined)
vicb
reviewed
Jul 21, 2017
Contributor
There was a problem hiding this comment.
couldn't ctxChange be undefined here ?
Member
Author
There was a problem hiding this comment.
Nope, since the only way to get into this case would be to also change the templateRef. But this, in turn, would mean that we need to recreate view so wouldn't get into the else branch here.
In any case I've added a new test, just to be safe in the future (for example if we decide another @Input to the NgTemplateOutlet).
Contributor
There was a problem hiding this comment.
Could you please re-structure the code to improve clarity ?
- add comments,
- move
ctxChange.isFirstChange()out of_hasContextShapeChangedso that the method actually does what it says (alternative is to rename the methods & add comments).
pkozlowski-opensource
force-pushed
the
template_outlet_context_recreate
branch
from
July 24, 2017 14:58
d5f1e98 to
f0c578e
Compare
vicb
reviewed
Jul 24, 2017
Contributor
There was a problem hiding this comment.
null should be undefined, right ?
pkozlowski-opensource
force-pushed
the
template_outlet_context_recreate
branch
from
July 25, 2017 08:58
f0c578e to
14713de
Compare
Member
Author
|
@vicb added comments, split code into smaller functions and simplified logic. Hopefully it is easier to follow now. PTAL |
Contributor
|
Change looks good but definitely a change in behavior. Should we merge in 4.x ? |
vicb
changed the title
Problem description: when using ngTemplateOutlet with context as an object literal in a template and binding to the context's property the embedded view would get re-created even if context object remains essentially the same (the same shape, just update to one properties). This happens since currently change detection will re-create object references when an object literal is used and one of its properties gets updated through a binding. Solution: this commit changes ngTemplateOutlet logic so we take contex't object shape into account before deciding if we should re-create view or just update existing context. Fixes angular#13407
pkozlowski-opensource
force-pushed
the
template_outlet_context_recreate
branch
from
August 7, 2017 18:16
14713de to
2871389
Compare
pkozlowski-opensource
added
the
target: major
vicb
approved these changes
Aug 7, 2017
vicb
added
action: merge
asnowwolf
pushed a commit
to asnowwolf/angular
that referenced
this pull request
Aug 11, 2017
…ngular#18277) Problem description: when using ngTemplateOutlet with context as an object literal in a template and binding to the context's property the embedded view would get re-created even if context object remains essentially the same (the same shape, just update to one properties). This happens since currently change detection will re-create object references when an object literal is used and one of its properties gets updated through a binding. Solution: this commit changes ngTemplateOutlet logic so we take context object shape into account before deciding if we should re-create view or just update existing context. Fixes angular#13407
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 26, 2017
…ngular#18277) Problem description: when using ngTemplateOutlet with context as an object literal in a template and binding to the context's property the embedded view would get re-created even if context object remains essentially the same (the same shape, just update to one properties). This happens since currently change detection will re-create object references when an object literal is used and one of its properties gets updated through a binding. Solution: this commit changes ngTemplateOutlet logic so we take context object shape into account before deciding if we should re-create view or just update existing context. Fixes angular#13407
juleskremer
pushed a commit
to juleskremer/angular
that referenced
this pull request
Aug 28, 2017
…ngular#18277) Problem description: when using ngTemplateOutlet with context as an object literal in a template and binding to the context's property the embedded view would get re-created even if context object remains essentially the same (the same shape, just update to one properties). This happens since currently change detection will re-create object references when an object literal is used and one of its properties gets updated through a binding. Solution: this commit changes ngTemplateOutlet logic so we take context object shape into account before deciding if we should re-create view or just update existing context. Fixes angular#13407
2 of 8 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13407
Problem description
When using
ngTemplateOutletwith context as an object literal in a template and binding to the context's property the embedded view would get re-created even if context object remains essentially the same (the same shape, just update to one properties).This happens since currently change detection will re-create object references when an object literal is used and one of its properties gets updated through a binding.
Solution proposal
This PR changes
ngTemplateOutletlogic so we take contex't object shape into account before deciding if we should re-create view or just update existing context.