feat(upgrade): provide test helpers for wiring up injectors - #16848

Looking good! I think we need some more documentation on how to use this. Can this be part of the API docs?

I'll add docs but wanted feedback on whether this is the right API first.

As a reminder, the helpers need to be exported and upgrade/testing should be added to a bunch of lists for it to appear in the docs etc.

Ping?

Sorry I have been distracted. I will tidy it up this week.

I have made the suggested changes, where appropriate, added documentation and included this new module in as many configuration files as I could find.

PTAL: @mhevery @juliemr @gkalpak

And of course this PR falls foul of the change from CircleCI v1 to v2.

Just checking to see if closing and reopening helps with CircleCI

Hi @petebacondarwin, I am just wondering what the rough timeline for this to be release will be?

@kieranblight - I have been having difficulties getting the new package into the system. I hope to finish this and get it in by the end of this week.

@petebacondarwin thank you, look forward to it :)!

You can preview ba85f2e at https://pr16848-ba85f2e.ngbuilds.io/.

You can preview c4c98e4 at https://pr16848-c4c98e4.ngbuilds.io/.

You can preview b9193f6 at https://pr16848-b9193f6.ngbuilds.io/.

You can preview 81184b9 at https://pr16848-81184b9.ngbuilds.io/.

You can preview 5984a60 at https://pr16848-5984a60.ngbuilds.io/.

We should also provide an "injector only version" that does not require a full TestBed to be compiled. E.g. Something like this (thanks to @jbedard)

export function provideInjector(...providers: StaticProvider[]) {
    return function($provide: angular.auto.IProvideService) {
        $provide.factory("$$angularInjector", ["$injector", function($injector: angular.auto.IInjectorService) {
            return Injector.create([
                ...providers,
                {provide: "$injector", useValue: $injector}
            ]);
        }]);
        $provide.factory("$$angularLazyModuleRef", ["$$angularInjector", (injector) => ({injector, needsNgZone: true})]);
    };
}

Would be cool if this got merged in! 😬

@pburgmer (regarding #16848 (comment)). There is a bug in the stringify() method of the Angular compiler, which a commit in this PR now fixes.

Looks like the failure is legit. I'll have to work on that.

@petebacondarwin any plans to get this in soon? do appreciate the work going on here.

@fzxt - I will need help resolving the Windows CI failures...

Ping? It would be nice to get these helpers in soon. Can any googlers help out with the review?

@jasonaden is working on it :-)

any expectations on when this is going to be finished?

thanks!

Apart from the conflicts it is ready to be reviewed. It is unlikely to land before 8.2 or 9 now.
I'll rebase tomorrow and chase someone (like @IgorMinar) to take a view.

VE presubmit

Presubmit indicated that we need to perform additional changes in build files in g3 to land this PR. I've added "cleanup" label for now and will look into the build files update asap. Thank you.

Thanks @AndrewKushnir

New VE presubmit, including g3 changes.

Note to Caretaker: this PR requires additional change in g3: cl/254085499, to update BUILD file with extra rules to build upgrade/testing package.

For anyone who finds this thread in the future, these helpers are available. Check out the docs here: https://angular.io/api/upgrade/static/testing

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}