Skip to content

fix(aio): remove max width on marketing pages and footer - #16459

Merged
matsko merged 1 commit into
angular:masterfrom
sjtrimble:marketing-footer-layout-fix
May 1, 2017
Merged

fix(aio): remove max width on marketing pages and footer#16459
matsko merged 1 commit into
angular:masterfrom
sjtrimble:marketing-footer-layout-fix

Conversation

@sjtrimble

@sjtrimble sjtrimble commented May 1, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sjtrimble
fix(aio): remove max width on marketing pages and footer
b474ff6 
- Removed the max-width on all marketing pages
- Moved the footer so that it extends fully horizontally on all screen sizes
@sjtrimble sjtrimble self-assigned this May 1, 2017
@sjtrimble sjtrimble added comp: aio action: review The PR is still awaiting reviews from at least one requested reviewer labels May 1, 2017
@mary-poppins

mary-poppins commented May 1, 2017

Copy link
Copy Markdown

The angular.io preview for b474ff6 is available here.

@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 1, 2017
@matsko
matsko merged commit c8fd904 into angular:master May 1, 2017
@aravindfz aravindfz mentioned this pull request Jul 18, 2017
Closed
1 task done
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 11, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@petebacondarwin petebacondarwin petebacondarwin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@sjtrimble sjtrimble

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aio: fixed maximum width content makes home page look weird

5 participants

@sjtrimble @mary-poppins @petebacondarwin @matsko @googlebot