feat(compiler-cli): add i18n parameters to tsconfig - #16365

you can remove this line "you should ..."
same below

|| sourceFormat at the end (useful when they are the same)

For xmb/xtb source & target format are different, this could lead to bugs. The only case where this would work would be for xlf and it's already the default format.

Please take the opportunity of this PR to clean the (...)! hack.

As a general comment on this PR, "source" is confusing because it relates to the file being written which is counter-intuitive - same for "target".

Can you think about better names ?

should be locale ?

I wanted to be sure if you really paid attention to the code.

Jokes aside, good catch, fixed

move this to the top with other parameters ?
explain why we do || options.i18nTranslationFormat (ie most files contain both messages and translations)

same thing here, move init to the top, missing i18nTranslationFormat here

format could not be null -> || '' at the end

forget my first comment, you have updated the API

We don't use "i18nTranslationFormat" for the extraction (this is ng-xi18n, not ngc)

move init at the top

specify the possible values in the comment

set the default to xliff

revert |null

also for the other methods if possible

why this change ?

It's the only way that I found to add the unit test. I can remove it, but I'll have to remove the test as well

same, add xliff by default

this is probably confusing.

"compilerOptions": {
  "outDir": "foo",
  "out": "bar"
},
"angularCompilerOptions": {
  "outFile": "baz"
}

I think either these options need to have i18n in the name, or be nested:

"angularCompilerOptions": {
  "i18n_msgs": {
    "extract": {
      "outFile": "msgs.xtb"
    },
    "merge": {
      "i18nFile": "msgs.xtb"
    }
  }
}

WDYT?

We used the names of the current cli options (when possible). We can nest them though, what do you think @vicb ?

it's not possible to nest the options:
type CompilerOptionsValue = string | number | boolean | (string | number)[] | string[] | MapLike<string[]> | PluginImport[];

Isn't MapLike<string[]> the way to nest options? TypeScript does nest them, eg. compilerOptions.paths

I was expecting multiple locales to appear here. Users shouldn't have N tsconfig files (and note that the tsconfig "extends" behavior doesn't cover unknown config properties like "angularCompilerOptions")

This is the locale used for extracted messages, which is the main locale of your application. There is only one here since you only do one extraction.
You are referring to translationLocale?: string; which is the locale used when you compile the application. I had a comment there that @vicb told me remove which was something like "only use this if you have one tsconfig file / locale".
I agree that it would be better if we could compile all locales in one command, but that is not possible yet. There's a bit refactor coming for the compiler and it will probably change at that point, but for now we can only compile for one locale.