Skip to content

fix(compiler-cli): add fallback to xlf format to extractor #16338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
denyo wants to merge 2 commits into from
Closed

fix(compiler-cli): add fallback to xlf format to extractor #16338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1de4d5d
fix(compiler-cli): add fallback to xlf format to extractor
denyo Apr 26, 2017
de7276e
fix(compiler-cli): set xlf as default in I18nExtractionCliOptions
denyo Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/ci/offline_compiler_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ cp -v package.json $TMP

./node_modules/.bin/ngc -p tsconfig-build.json --i18nFile=src/messages.fi.xlf --locale=fi --i18nFormat=xlf

./node_modules/.bin/ng-xi18n -p tsconfig-xi18n.json --locale=fr
./node_modules/.bin/ng-xi18n -p tsconfig-xi18n.json --i18nFormat=xlf --locale=fr
./node_modules/.bin/ng-xi18n -p tsconfig-xi18n.json --i18nFormat=xlf2 --outFile=messages.xliff2.xlf
./node_modules/.bin/ng-xi18n -p tsconfig-xi18n.json --i18nFormat=xmb --outFile=custom_file.xmb
Expand Down
2 changes: 1 addition & 1 deletion tools/@angular/tsc-wrapped/src/cli_options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export class I18nExtractionCliOptions extends CliOptions {
locale: string|null;
outFile: string|null;

constructor({i18nFormat = null, locale = null, outFile = null}: {
constructor({i18nFormat = 'xlf', locale = null, outFile = null}: {
i18nFormat?: string,
locale?: string,
outFile?: string,
Expand Down