Skip to content

feat(aio): layout max width and design cleanup - #16301

Merged
petebacondarwin merged 1 commit into
angular:masterfrom
sjtrimble:design-phase-10
Apr 26, 2017
Merged

feat(aio): layout max width and design cleanup#16301
petebacondarwin merged 1 commit into
angular:masterfrom
sjtrimble:design-phase-10

Conversation

@sjtrimble

@sjtrimble sjtrimble commented Apr 25, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Content container now has a max width and made the body background the same offwhite color so the cut-off is not visible
  • Sidenav will always remain at the left of the page
  • Added a max width to the api banner of filter search inputs

Closes #16098 (comment)

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@sjtrimble sjtrimble self-assigned this Apr 25, 2017
@mary-poppins

mary-poppins commented Apr 25, 2017

Copy link
Copy Markdown

The angular.io preview for abea275184e470ef692da2999e7bdfb36d5e011a is available here.

gkalpak
gkalpak approved these changes Apr 25, 2017
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it LGT @sjtrimble 😃

I might prefer the banner the be the same width as the .sidenav-container. Or even not have a banner at all.
But that is a different discussion.

@petebacondarwin

petebacondarwin commented Apr 25, 2017

Copy link
Copy Markdown
Contributor

I think the document contents should not be centered in the page when the window is wide.

screen shot 2017-04-25 at 12 33 33

It should be left aligned to the side nav.

@mary-poppins

mary-poppins commented Apr 25, 2017

Copy link
Copy Markdown

The angular.io preview for 5421d1d9ae391bdccacea606826939bb0ff9f6c6 is available here.

@sjtrimble
feat(aio): layout max width and design cleanup
b6458d8 
- Content container now has a max width and made the body background the same offwhite color so the cut-off is not visible
- Sidenav will always remain at the left of the page
- Added a max width to the api banner of filter search inputs
- Left aligned content container so it is flush with sidenav
- Changed API filter width to match size of filter results
@sjtrimble sjtrimble changed the title WIP feat(aio): layout max width and design cleanup feat(aio): layout max width and design cleanup Apr 25, 2017
@sjtrimble

sjtrimble commented Apr 25, 2017

Copy link
Copy Markdown
Contributor Author

@petebacondarwin @gkalpak I implemented both your comments, should be ready for full review now

@mary-poppins

mary-poppins commented Apr 25, 2017

Copy link
Copy Markdown

The angular.io preview for b6458d8 is available here.

@sjtrimble sjtrimble added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Apr 25, 2017
@gkalpak

gkalpak commented Apr 25, 2017

Copy link
Copy Markdown
Member

I am happy with the banner. Still LGTM 😃

@sjtrimble sjtrimble mentioned this pull request Apr 25, 2017
Closed
@petebacondarwin petebacondarwin mentioned this pull request Apr 26, 2017
Closed
@petebacondarwin

petebacondarwin commented Apr 26, 2017

Copy link
Copy Markdown
Contributor

Merging but please take a look at #16337 @sjtrimble

@petebacondarwin
petebacondarwin merged commit 710b4a3 into angular:master Apr 26, 2017
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 11, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@sjtrimble sjtrimble

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API page uses inconsistent alignment of visual elements

5 participants

@sjtrimble @mary-poppins @petebacondarwin @gkalpak @googlebot