Skip to content

fix(compiler-cli): set default format to xlf for serialize - #16273

Closed
ocombe wants to merge 1 commit into
angular:masterfrom
ocombe:fix-default-format-16235
Closed

ocombe wants to merge 1 commit into
angular:masterfrom
ocombe:fix-default-format-16235

Conversation

@ocombe

@ocombe ocombe commented Apr 24, 2017 •

Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?
Fixes a regression introduced with the new XLIFF2 format. See #16235.

What is the new behavior?
Default format for this function is xlf

Does this PR introduce a breaking change?

[x] No

@ocombe ocombe added the area: i18n Issues related to localization and internationalization label Apr 24, 2017
@ocombe
ocombe requested a review from vicb April 24, 2017 08:31
@ocombe ocombe added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 27, 2017
@ocombe ocombe closed this Apr 28, 2017
@ocombe ocombe reopened this Apr 28, 2017
@ocombe

ocombe commented Apr 28, 2017

Copy link
Copy Markdown
Contributor Author

Closing this, I fix the bug in #16365

@ocombe ocombe closed this Apr 28, 2017
@ocombe
ocombe deleted the fix-default-format-16235 branch June 8, 2017 08:20
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: i18n Issues related to localization and internationalization cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants