fix(aio): allow empty titles for contents pages#16149
Merged
petebacondarwin merged 1 commit intoangular:masterfrom Apr 19, 2017
Merged
fix(aio): allow empty titles for contents pages#16149petebacondarwin merged 1 commit intoangular:masterfrom
petebacondarwin merged 1 commit intoangular:masterfrom
Conversation
gkalpak
approved these changes
Apr 19, 2017
Member
gkalpak
left a comment
gkalpak
left a comment
There was a problem hiding this comment.
LGTM as soon as Travis is happy.
Member
There was a problem hiding this comment.
I wouldn't mind having a non-empty name too (just to cover more cases).
|
The angular.io preview for 2de87aab3840c7dc5c023cd44811ce5fd6c8d38b is available here. |
petebacondarwin
force-pushed
the
aio-allow-empty-titles
branch
from
2de87aa to
19fce98
Compare
Contributor
Author
|
I fixed a typo in the commit message |
|
The angular.io preview for 19fce980c14315c74f2de1db3d054b0ca94b4abc is available here. |
Now if you specifically provide an empty `@title` tag for a contents file, the doc-gen will not complain and the browser will just display a reasonable default.
petebacondarwin
force-pushed
the
aio-allow-empty-titles
branch
from
19fce98 to
2f00738
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now if you specifically provide an empty
@titletagfor a contents file, the doc-gen will not complain and
the browser will just display a reasonable default.
See #16089 (comment)