Conversation
|
The angular.io preview for 8d2c043698d07c1cb9d4a5268bac40a261f00dce is available here. |
There was a problem hiding this comment.
so this will change to #file-not-found
|
The angular.io preview for c130c3374927f9e37e19d63b38dc66adde85343b is available here. |
|
Thanks @petebacondarwin :) I changed it |
aio/content/file-not-found.md
Outdated
There was a problem hiding this comment.
width and height attributes hold the "intrinsic width/height of the image in pixels". You only need to specify the numeric value (the rest is ignored).
There was a problem hiding this comment.
also there should be no extra commas in the value strings.
aio/content/file-not-found.md
Outdated
There was a problem hiding this comment.
Having a title here, adds an h1 heading to the page that doesn't look inline with the rest of the design.
(Not sure what the correct solution is for such cases.)
There was a problem hiding this comment.
The problem here is that Pete will report it as an error (which a missing title would be normally).
A solution would be to style that <h1> so it disappears.
There was a problem hiding this comment.
How about we allow an empty @title tag, which indicates that we explicitly do not want a heading?
There was a problem hiding this comment.
won't that be error-prone? how about we allowed @title VOID instead?
There was a problem hiding this comment.
It is not that error prone because it is very unlikely that someone would add a @title tag and forget to add a title.
The support for this landed a few hours ago.
I just realised though that this might not be necessary. If no title is provided via @title then the content is searched for the first h1 element.
So if @sjtrimble changes the file so that <h2>Page Not Found</h2> becomes <h1>Page Not Found</h1> then we can ditch the @title and @description tags from the file altogether.
There was a problem hiding this comment.
Wouldn't that render the title (which is exactly what we are trying to prevent)?
There was a problem hiding this comment.
As I understand it, we do want a heading (there is already a h2 there) but not at the top of the page. The thing about adding a title via the @title tag is that it automatically adds a h1 at the top of the page.
There was a problem hiding this comment.
Oh, I see. Then, I agree this could be solved by removing the @title and changing the h2 to h1 (and styling it appropriately).
aio/content/file-not-found.md
Outdated
There was a problem hiding this comment.
The problem here is that Pete will report it as an error (which a missing title would be normally).
A solution would be to style that <h1> so it disappears.
There was a problem hiding this comment.
As we discussed, a lighter weight alternative is an MD icon such as seen in the network fail page PR #16139.
I would merge this now and wait to change it a later PR.
|
@IgorMinar This builds on top of Pete's PR which has a specific section ID that I use to override the h1 all together so it's hidden. I can make a sad face instead :) |
5bfa352 to
b2999f6
Compare
|
I have made the changes - new icon, no @title on the .md, and custom h1 styling. |
|
The angular.io preview for 5bfa352c6427bf9735101cf389c9591b2628fac0 is available here. |
aio/content/file-not-found.md
Outdated
There was a problem hiding this comment.
You can remove this @description as well :-)
|
The angular.io preview for b2999f624387f3fb764e753f6c0e624125d57c94 is available here. |
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM - let's merge it and iterate on the fine tuning of the design if necessary.
Add 404 svg image h1 custom styling
Add 404 svg image h1 custom styling PR Close angular#16089
Add 404 svg image h1 custom styling PR Close angular#16089
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |

404 page styling with graphic. Builds off of #16085 lands.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")